Skip to content

Types used only in extern blocks seem to be dead #10939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
emberian opened this issue Dec 12, 2013 · 3 comments
Closed

Types used only in extern blocks seem to be dead #10939

emberian opened this issue Dec 12, 2013 · 3 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints

Comments

@emberian
Copy link
Member

compile librustdoc/lib.rs for example. it marks struct buf as dead.

cc @ktt3ja
@ktt3ja
Copy link
Contributor

ktt3ja commented Dec 13, 2013

Hmm, strange. I thought I already handled that case. I even have a test case for it:
https://github.com/mozilla/rust/blob/1b12dca7f97a51c6cbb4f47ea6e095d841a97c1a/src/test/compile-fail/lint-dead-code-3.rs#L45-L50

@huonw
Copy link
Member

huonw commented Dec 13, 2013

Shouldn't that test-case actually warn because free is unused and not exported?

@ktt3ja ktt3ja mentioned this issue Dec 14, 2013
Merged
bors added a commit that referenced this issue Dec 14, 2013
@bors
auto merge of #10870 : ktt3ja/rust/issue-10865, r=alexcrichton
3d3a663 
Fix #10865 and #10939.
@huonw
Copy link
Member

huonw commented Dec 15, 2013

Fixed by #10870.

@huonw huonw closed this as completed Dec 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emberian @huonw @ktt3ja