Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify attribute parsing #1094

Closed
brson opened this issue Oct 29, 2011 · 1 comment
Closed

Simplify attribute parsing #1094

brson opened this issue Oct 29, 2011 · 1 comment
Assignees
@brson
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Milestone
old 1.0 milestone

Comments

@brson
Copy link
Contributor

brson commented Oct 29, 2011

There may be enough lookahead in the parser to simplify attribute parsing, which is quite intricate.
@ghost ghost assigned brson Apr 12, 2012
@marijnh
Copy link
Contributor

marijnh commented May 8, 2012

Seeing the difference between #[foo] (without semicolon) and #[foo];, where foo can be any nested attribute expression, requires arbitrary lookahead. I assume that is what this issue is referring to. We've been actively avoiding arbitrary lookahead in other cases, so I'm closing this issue on the assumption that we don't want it here either.

@marijnh marijnh closed this as completed May 8, 2012
@owaspjocur owaspjocur mentioned this issue Nov 5, 2013
Merged
bjorn3 added a commit to bjorn3/rust that referenced this issue Oct 26, 2020
@l4l @bjorn3
Use architecture pointer size for AddConstructor (rust-lang#1094)
0409177 
* Use architecture pointer size for AddConstructor

* Update src/backend.rs

Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@adpaco-aws @tedinski
Audit for offset intrinsic (rust-lang#1094)
b8369e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brson brson

Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
old 1.0 milestone
Development

No branches or pull requests
2 participants
@marijnh @brson