-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust.codegen-backends
interacts confusingly with paths
#109610
Comments
@rustbot claim |
The first element in codegen-backends is used as default backend. In addition even if the CodegenBackend step were to directly use the passed in paths, assembling the toolchain did still only add the backends in codegen-backends to the sysroot. Having path specifiers for one step affect another step doesn't feel right. For check builds I do agree this is an improvement. Although I personally actually use this behavior to have |
Does it make sense to separate cg_clif and cg_gcc into different steps in that case? cc @antoyo |
That doesn't have any effect on if specifying a backend as path will add it to the sysroot. |
…racts_confusingly_with_paths, r=Mark-Simulacrum check for missing codegen backeng config Fixes [rust-lang#109610](rust-lang#109610)
…racts_confusingly_with_paths, r=Mark-Simulacrum check for missing codegen backeng config Fixes [rust-lang#109610](rust-lang#109610)
I tried this code:
I expected this to happen: Bootstrap builds cranelift, since I named it explicitly.
Instead, this happened: Nothing, since I didn't have cranelift configured in
codegen-backends
:rust/src/bootstrap/compile.rs
Lines 998 to 1009 in ce6adcc
At a minimum, I would expect this to give an error or warning that I need to configure codegen-backends. It would be even nicer if we could treat
codegen-backends
as only controlling the defaults, instead of as a hard-off switch, like howrust.compiler-docs
works. That should be possible to do by looking at therun.paths
we're passed.cc @bjorn3
The text was updated successfully, but these errors were encountered: