LLVM 17 regression: tests/ui/abi/stack-protector.rs no longer actually attempts stack-smashing #109671
Assignees
Labels
A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
A-testsuite
Area: The testsuite used to check the correctness of rustc
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Mar 27, 2023
tests/ui/abi/stack-protector.rs: rust-lang/rust#109671 the test is being optimized in newer LLVM which breaks its expectations. tests/ui/backtrace.rs: rust-lang/rust#109672 the second panic in a double-panic is being optimized out (reasonably correctly) by newer LLVM. Bug: b/274802621, 1401042 Change-Id: I2be621f38dd1630c13eaf9128c76e0d17d684367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4375277 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/main@{#1122545}
|
@rustbot label +A-llvm |
rustbot
added
the
A-LLVM
jyn514
added
the
A-testsuite
Noratrieb
added
the
T-compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
LLVM change 0d4a709 (https://reviews.llvm.org/D145210) appears to have broken the test for stack-protection. tests/ui/abi/stack-protector.rs fails both with and without stack protection enabled, because the test now makes it to the
TEST BUG: stack smash unsuccessfulpanic, presumably because something new in LLVM's optimizations skips the stack smash.Filing this bug and disabling the test in our Rust/LLVM HEADs CI for now so we see other (more urgent) breakage reliably.
The text was updated successfully, but these errors were encountered: