Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize vec::MoveIterator for POD types #10976

Closed
erickt opened this issue Dec 15, 2013 · 1 comment · Fixed by #10995
Closed

Optimize vec::MoveIterator for POD types #10976

erickt opened this issue Dec 15, 2013 · 1 comment · Fixed by #10995

Comments

@erickt
Copy link
Contributor

erickt commented Dec 15, 2013

vec::MoveIterator is written in such a way to be safe for dtors, but this is unnecessary overhead for POD types. Because vec is such an important type, it's worth optimizing for this case. I think all we need is to make use of std::libstd::needs_drop(), but I'm not completely sure if that's all that is needed.
@erickt
Copy link
Contributor Author

erickt commented Dec 15, 2013

I have an experimental implementation of this in this gist. It's roughly twice as fast, but I'm not sure if it's safe yet. It's still 10% slower than v.iter().map(|x| *x) though.

@thestinger thestinger mentioned this issue Dec 16, 2013
Merged
bors added a commit that referenced this issue Dec 16, 2013
@bors
auto merge of #10995 : thestinger/rust/fast_move_iter, r=huonw
7b42497 
Closes #10976

Taken from https://github.com/thestinger/rust-core/commit/863fbaaa125f1bb290e28cbf22236406cf0aebcf, so it will be easily updated to the better vector representation too.
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 30, 2023
@bors
Auto merge of rust-lang#10976 - dswij:issue-10966, r=Alexendoo
8c8ff5f 
Make [`missing_panics_doc`]  not lint for `todo!()`

closes rust-lang#10966

changelog: [`missing_panics_doc`] now does not lint for `todo!()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vec: make the move iterator fast for all types
1 participant
@erickt