Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run-pass tests in tests/ui-fulldeps/ fall when download-rustc is enabled #110225

Closed
jyn514 opened this issue Apr 12, 2023 · 0 comments · Fixed by #110263
Closed

run-pass tests in tests/ui-fulldeps/ fall when download-rustc is enabled #110225

jyn514 opened this issue Apr 12, 2023 · 0 comments · Fixed by #110263
Assignees
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-download-rustc Area: The `rust.download-rustc` build option. C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Apr 12, 2023

I tried this code: ./configure --set profile=compiler --set rust.download-rustc && x test ui-fulldeps

I expected to see this happen: All tests pass.

Instead, this happened:

failures:
    [ui] tests/ui-fulldeps/deriving-encodable-decodable-cell-refcell.rs
    [ui] tests/ui-fulldeps/compiler-calls.rs
    [ui] tests/ui-fulldeps/issue-14021.rs
    [ui] tests/ui-fulldeps/deriving-encodable-decodable-box.rs
    [ui] tests/ui-fulldeps/stable-mir/crate-info.rs
    [ui] tests/ui-fulldeps/mod_dir_path_canonicalized.rs
    [ui] tests/ui-fulldeps/pprust-expr-roundtrip.rs

test result: FAILED. 63 passed; 7 failed; 1 ignored; 0 measured; 0 filtered out; finished in 3.14s

The failures all look like this:

---- [ui] tests/ui-fulldeps/pprust-expr-roundtrip.rs stdout ----

error: test run failed!
status: exit status: 127
command: cd "/home/jyn/src/rust2/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/pprust-expr-roundtrip" && RUST_TEST_THREADS="16" "/home/jyn/src/rust2/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/pprust-expr-roundtrip/a"
stdout: none
--- stderr -------------------------------
/home/jyn/src/rust2/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/pprust-expr-roundtrip/a: error while loading shared libraries: libLLVM-16-rust-1.70.0-nightly.so: cannot open shared object file: No such file or directory
------------------------------------------

I see the following llvm .so files in the build directory:

; fd libLLVM build/host/ci-rustc*
build/host/ci-rustc/lib/libLLVM-16-rust-1.70.0-nightly.so
build/host/ci-rustc-sysroot/lib/libLLVM-16-rust-1.70.0-nightly.so

but with the rustc-dev component added, it should also be in the rustlib target folder:

; ls $(rustc --print sysroot)/lib/rustlib/x86_64-unknown-linux-gnu/lib/libLLVM*
/home/jyn/.local/lib/rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libLLVM-16-rust-1.70.0-nightly.so

Meta

HEAD is f2d9a3d

@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-download-rustc Area: The `rust.download-rustc` build option. labels Apr 12, 2023
@jyn514 jyn514 self-assigned this Apr 13, 2023
@bors bors closed this as completed in 276fa29 Apr 14, 2023
oli-obk pushed a commit to oli-obk/miri that referenced this issue Apr 17, 2023
Add `libLLVM.so` to the target libdir when download-rustc is enabled

Previously, we would only add it to the host libdir, which meant it couldn't be loaded by `ui-fulldeps` tests that used rustc_private.

Fixes rust-lang/rust#110225, fixes rust-lang/rust#110226.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-download-rustc Area: The `rust.download-rustc` build option. C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant