Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbuild: some x.py targets no longer print their dependencies being built #110506

Closed
matthiaskrgr opened this issue Apr 18, 2023 · 9 comments · Fixed by #110507
Closed

rustbuild: some x.py targets no longer print their dependencies being built #110506

matthiaskrgr opened this issue Apr 18, 2023 · 9 comments · Fixed by #110507
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@matthiaskrgr
Copy link
Member

When running x.py install for example, x.py would previously show the build (cargo) output when building cargo during x.py install, but that is no longer the case. Is that intentional?

....
Uplifting rustc (stage1 -> stage3)
Building tool cargo (stage2 -> stage3)
Building tool cargo-credential-1password (stage2 -> stage3)
Dist cargo-1.71.0-dev-x86_64-unknown-linux-gnu
	finished in 2.176 seconds
Install cargo stage2 (Some(x86_64-unknown-linux-gnu))
@matthiaskrgr matthiaskrgr added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Apr 18, 2023
@albertlarsan68
Copy link
Member

It's not intentional AFAIK, but I don't see a recent PR that could have broken this off the top of my head.
Do you have a commit/timeframe where this worked correctly?

@matthiaskrgr
Copy link
Member Author

Hmm I would guess it still worked last weekend?

@jyn514
Copy link
Member

jyn514 commented Apr 18, 2023

Are you sure cargo is actually being built? stage2 -> stage3 makes me think it's using cached stage 2 artifacts.

@matthiaskrgr
Copy link
Member Author

Might be 103ed0e

@matthiaskrgr
Copy link
Member Author

Yes, I can see rustc building cargo and its deps in htop while x.py does not print any updates 😅

@jyn514
Copy link
Member

jyn514 commented Apr 18, 2023

oh lol that would do it

cc @weihanglo

@weihanglo
Copy link
Member

Sounds like we do need stream_cargo there? I'll put it back then!

@albertlarsan68
Copy link
Member

Is there not a try_run way of doing things?

@jyn514
Copy link
Member

jyn514 commented Apr 18, 2023

Yes, there's a try_run, that would be best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants