Skip to content

bors is broken #11116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
emberian opened this issue Dec 22, 2013 · 1 comment
Closed

bors is broken #11116

emberian opened this issue Dec 22, 2013 · 1 comment

Comments

@emberian
Copy link
Member

Sample: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2259/steps/clean/logs/stdio

cc @brson @alexcrichton
@alexcrichton
Copy link
Member

Looks like win1 just needed a reboot.

flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 31, 2023
@bors
Auto merge of rust-lang#11116 - y21:format_collect, r=Manishearth
410456d 
new lint: `format_collect`

A perf lint that looks for `format!`ing inside of `map`, then collecting it into a `String`. Did a quick benchmark locally and it's a bit more than 2x faster with fold.
`write!` is still not optimal (presumably because the fmt stuff goes through dynamic dispatch), but it's still a lot better than creating a new string on every element.
I thought about making a machine applicable suggestion, but there's a lot of suggestions that need to be made here, so I decided to just add help messages.

changelog: new lint: `format_collect`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @emberian