Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: ImplTrait vs. Ctor expected ICE #111484

Closed
Mark-Simulacrum opened this issue May 11, 2023 · 2 comments
Closed

regression: ImplTrait vs. Ctor expected ICE #111484

Mark-Simulacrum opened this issue May 11, 2023 · 2 comments
Assignees
@compiler-errors
Labels
I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ P-medium Medium priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
1.70.0

Comments

@Mark-Simulacrum
Copy link
Member

https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/zdata-inc.kustd/log.txt

[INFO] [stderr] thread 'rustc' panicked at 'assertion failed: `(left == right)`
[INFO] [stderr]   left: `ImplTrait`,
[INFO] [stderr]  right: `Ctor`', compiler/rustc_metadata/src/rmeta/decoder.rs:1127:17
[INFO] [stderr] stack backtrace:
@Mark-Simulacrum Mark-Simulacrum added I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels May 11, 2023
@Mark-Simulacrum Mark-Simulacrum added this to the 1.71.0 milestone May 11, 2023
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 11, 2023
@Mark-Simulacrum Mark-Simulacrum mentioned this issue May 12, 2023
Closed
@compiler-errors compiler-errors self-assigned this May 12, 2023
@compiler-errors compiler-errors mentioned this issue May 12, 2023
Merged
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.71.0, 1.70.0 May 13, 2023
@apiraino
Copy link
Contributor

WG-prioritization assigning priority (Zulip discussion).

@rustbot label -I-prioritize +P-medium

@rustbot rustbot added P-medium Medium priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels May 16, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue May 18, 2023
@Dylan-DPC
Rollup merge of rust-lang#111491 - compiler-errors:nested-fut-must-us…
93fd6fc 
…e, r=wesleywiser

Dont check `must_use` on nested `impl Future` from fn

Fixes (but does not close, per beta policy) rust-lang#111484

Also fixes a `FIXME` left in the code about (presumably) false-positives on non-async `#[must_use] fn() -> impl Future` cases, though if that's not desirable to include in the beta backport then I can certainly revert it.

Beta nominating as it fixes a beta ICE.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue May 19, 2023
@matthiaskrgr
Rollup merge of rust-lang#111491 - compiler-errors:nested-fut-must-us…
cd8826e 
…e, r=wesleywiser

Dont check `must_use` on nested `impl Future` from fn

Fixes (but does not close, per beta policy) rust-lang#111484

Also fixes a `FIXME` left in the code about (presumably) false-positives on non-async `#[must_use] fn() -> impl Future` cases, though if that's not desirable to include in the beta backport then I can certainly revert it.

Beta nominating as it fixes a beta ICE.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue May 19, 2023
@GuillaumeGomez
Rollup merge of rust-lang#111491 - compiler-errors:nested-fut-must-us…
477cc24 
…e, r=wesleywiser

Dont check `must_use` on nested `impl Future` from fn

Fixes (but does not close, per beta policy) rust-lang#111484

Also fixes a `FIXME` left in the code about (presumably) false-positives on non-async `#[must_use] fn() -> impl Future` cases, though if that's not desirable to include in the beta backport then I can certainly revert it.

Beta nominating as it fixes a beta ICE.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue May 19, 2023
@GuillaumeGomez
Rollup merge of rust-lang#111491 - compiler-errors:nested-fut-must-us…
957104b 
…e, r=wesleywiser

Dont check `must_use` on nested `impl Future` from fn

Fixes (but does not close, per beta policy) rust-lang#111484

Also fixes a `FIXME` left in the code about (presumably) false-positives on non-async `#[must_use] fn() -> impl Future` cases, though if that's not desirable to include in the beta backport then I can certainly revert it.

Beta nominating as it fixes a beta ICE.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue May 20, 2023
@Dylan-DPC
Rollup merge of rust-lang#111491 - compiler-errors:nested-fut-must-us…
2294d81 
…e, r=wesleywiser

Dont check `must_use` on nested `impl Future` from fn

Fixes (but does not close, per beta policy) rust-lang#111484

Also fixes a `FIXME` left in the code about (presumably) false-positives on non-async `#[must_use] fn() -> impl Future` cases, though if that's not desirable to include in the beta backport then I can certainly revert it.

Beta nominating as it fixes a beta ICE.
@Mark-Simulacrum
Copy link
Member Author

Closing as fixed, fix is merged and backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compiler-errors compiler-errors

Labels
I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ P-medium Medium priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

No branches or pull requests
4 participants
@compiler-errors @Mark-Simulacrum @apiraino @rustbot