Skip to content

Unix pipes (named pipes on windows) need a 1:1 implementation #11201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexcrichton opened this issue Dec 30, 2013 · 2 comments · Fixed by #12103
Closed

Unix pipes (named pipes on windows) need a 1:1 implementation #11201

alexcrichton opened this issue Dec 30, 2013 · 2 comments · Fixed by #12103

Comments

@alexcrichton
Copy link
Member

This is an issue to track progress on the implementation of unix pipes (named pipes for windows) in 1:1 mode.

This will involve filling out the unix_bind and unix_connect functions inside of libnative/io/mod.rs
@Geal
Copy link
Contributor

Geal commented Jan 9, 2014

I am actually working on it because I need unix sockets right now, but the code is not much tested for now. I just sent it to my fork to work on it from elsewhere.

@Geal Geal mentioned this issue Jan 11, 2014
Closed
@Geal
Copy link
Contributor

Geal commented Jan 11, 2014

Ok, the code is now clean enough to warrant some testing :)

Here are some gists with working code to test those features: https://gist.github.com/Geal/8378309

It builds and works fine on an Ubuntu machine, I will now test it on OSX.

@brson brson mentioned this issue Feb 3, 2014
Closed
@alexcrichton alexcrichton mentioned this issue Feb 8, 2014
Merged
@itdaniher itdaniher mentioned this issue Feb 16, 2014
Closed
bors added a commit that referenced this issue Feb 18, 2014
@bors
auto merge of #12103 : alexcrichton/rust/unix, r=brson
62d7d00 
There's a few parts to this PR

* Implement unix pipes in libnative for unix platforms (thanks @Geal!)
* Implement named pipes in libnative for windows (terrible, terrible code)
* Remove `#[cfg(unix)]` from `mod unix` in `std::io::net`. This is a terrible name for what it is, but that's the topic of #12093.

The windows implementation was significantly more complicated than I thought it would be, but it seems to be passing all the tests. now.

Closes #11201
flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 31, 2023
@bors
Auto merge of rust-lang#11205 - Centri3:rust-lang#11201, r=Manishearth
d2c9047 
[`inherent_to_string`]: Don't lint `unsafe` or `extern` fns

Fixes rust-lang#11201

changelog: [`inherent_to_string`]: No longer lints `unsafe` or `extern` fns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@alexcrichton @Geal