bootstrap PGO artifact copies broken #113784
Labels
regression-from-stable-to-beta
Performance or correctness regression from stable to beta.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Milestone
Comments
Mark-Simulacrum
added
regression-from-stable-to-beta
rustbot
added
I-prioritize
Mark-Simulacrum
removed
I-prioritize
|
Maybe the simplest solution would just be to look up these files by their prefix? (We can also ignore the tests for beta/stable releases, but it probably is highly valuable to run these tests for them). |
This was referenced Jul 17, 2023
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jul 31, 2023
…mulacrum Resolve correct archive version name in `opt-dist` Should resolve the master part of rust-lang#113784. r? `@Mark-Simulacrum`
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Aug 1, 2023
…-Simulacrum Disable dist tests on beta/stable Should resolve the beta/stable part of rust-lang#113784. To be extra safe, I also made the read of `RUST_RELEASE_CHANNEL` optional, just in case it was missing. r? `@Mark-Simulacrum`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this issue
Aug 2, 2023
Resolve correct archive version name in `opt-dist` Should resolve the master part of rust-lang/rust#113784. r? `@Mark-Simulacrum`
|
I think the above two PRs should have fixed this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It looks like at least the old Python script hardcoded the channel as "nightly", which won't work on beta and stable branches.
27ff819 fixed this for last week's promotion from master -> beta, but it won't work on beta -> stable as that has yet another format.
We probably want to mirror the logic here: https://github.com/rust-lang/promote-release/blob/348f02569e3aff02187e90bbf532e63ccf62a268/src/main.rs#L451-L458, specifically the version part.
I think we'll want to land a commit on beta with the fix targeting stable, and a separate one on master -- given we just rewrote the script to Rust I'm not sure trying to backport something makes much sense. If the beta commit is tricky for some reason, we can skip that and just hardcode the version when running the next beta -> stable promotion.
cc @Kobzol -- maybe you can help work on this.
The text was updated successfully, but these errors were encountered: