Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot build Rust 1.71.1 with 1.71.0 #114444

Closed
heftig opened this issue Aug 4, 2023 · 6 comments
Closed

Cannot build Rust 1.71.1 with 1.71.0 #114444

heftig opened this issue Aug 4, 2023 · 6 comments
Labels
C-bug Category: This is a bug. P-critical Critical priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Milestone
1.72.0

Comments

@heftig
Copy link

heftig commented Aug 4, 2023

Apparently Rust 1.71.0 added a check that only allows it to be built with the exact same version of Rust, or a Rust that's one minor release older.

However, this also makes it impossible to build Rust 1.71.1 with a Rust that's one micro release older (1.71.0).

Unexpected rustc version: 1.71.0, we should use 1.70.x/1.71.1 to build source with 1.71.1

Is this really what was wanted? It makes it quite hard for us (Arch Linux) to build micro upgrades.
@heftig heftig added the C-bug Category: This is a bug. label Aug 4, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 4, 2023
@Mark-Simulacrum Mark-Simulacrum added the P-critical Critical priority label Aug 4, 2023
@Mark-Simulacrum Mark-Simulacrum added this to the 1.72.0 milestone Aug 4, 2023
@Mark-Simulacrum
Copy link
Member

No, this isn't intended. We should permit building with the previous release for point releases (minor and patch).

@ehuss
Copy link
Contributor

ehuss commented Aug 4, 2023

#114440 is open to fix this.

@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 4, 2023
@Noratrieb Noratrieb added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 4, 2023
@kaniini
Copy link
Contributor

kaniini commented Aug 4, 2023

#114440 has been merged I guess this can be closed?

@bjorn3
Copy link
Member

bjorn3 commented Aug 4, 2023

Nominated your PR for beta backporting in case 1.72 gets a patch release too.

@Mark-Simulacrum
Copy link
Member

1.72 is still in beta, so this'll get backported to that before the release.

@cuviper
Copy link
Member

cuviper commented Aug 14, 2023

#114440 was backported in #114748.

@cuviper cuviper closed this as completed Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. P-critical Critical priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.72.0
Development

No branches or pull requests
9 participants
@cuviper @ehuss @heftig @kaniini @Mark-Simulacrum @saethlin @bjorn3 @rustbot @Noratrieb