Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot write ICE files to disk on Windows hosts #115180

Closed
Enet4 opened this issue Aug 24, 2023 · 3 comments · Fixed by #116814
Closed

Cannot write ICE files to disk on Windows hosts #115180

Enet4 opened this issue Aug 24, 2023 · 3 comments · Fixed by #116814
Assignees
@estebank
Labels
C-bug Category: This is a bug. O-windows Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Enet4
Copy link
Contributor

Enet4 commented Aug 24, 2023

While investigating the ICE in #115179, I saw that every rustc attempt at writing the ICE details to a file (first implemented in #108714) would fail on my Windows machine with error messages of this kind:

warning: the ICE couldn't be written to `C:\Users\User\Dev\dicom-rs\rustc-ice-2023-08-24T17:31:34.9401158Z-146952.txt`: The filename, directory name, or volume label syntax is incorrect. (os error 123)

The timestamp format used for the file name separates time components with colons, and Windows is generally finicky about having colons in file names since it is already employed as the drive unit delimiter.

Could there be a change in the file name format for better compatibility, at least when running rustc on a Windows host?

Meta

rustc --version --verbose:

rustc 1.74.0-nightly (249595b75 2023-08-23)
binary: rustc
commit-hash: 249595b7523fc07a99c1adee90b1947739ca0e5b
commit-date: 2023-08-23
host: x86_64-pc-windows-msvc
release: 1.74.0-nightly
LLVM version: 17.0.0

@Enet4 Enet4 added the C-bug Category: This is a bug. label Aug 24, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 24, 2023
@saethlin saethlin added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 24, 2023
@Fulgen301
Copy link
Contributor

since it is already employed as the drive unit delimiter.

And for NTFS alternate data streams.

@ChrisDenton ChrisDenton added the O-windows Operating system: Windows label Aug 24, 2023
@matthiaskrgr
Copy link
Member

cc @estebank

@estebank
Copy link
Contributor

estebank commented Sep 8, 2023

Yes, we can change the format.

@SamRodri SamRodri mentioned this issue Sep 28, 2023
Open
estebank added a commit to estebank/rust that referenced this issue Oct 16, 2023
@estebank
Use YYYY-MM-DDTHH_MM_SS as datetime format for ICE dump files
8a2a747 
Windows paths do not support `:`, so use a datetime format in ICE dump
paths that Windows will accept.

Fix rust-lang#116809, fix rust-lang#115180.
@estebank estebank mentioned this issue Oct 16, 2023
Merged
@estebank estebank self-assigned this Oct 16, 2023
@estebank estebank mentioned this issue Oct 16, 2023
Closed
estebank added a commit to estebank/rust that referenced this issue Oct 16, 2023
@estebank
Use YYYY-MM-DDTHH_MM_SS as datetime format for ICE dump files
74e17b4 
Windows paths do not support `:`, so use a datetime format in ICE dump
paths that Windows will accept.

Fix rust-lang#116809, fix rust-lang#115180.
estebank added a commit to estebank/rust that referenced this issue Oct 16, 2023
@estebank
Use YYYY-MM-DDTHH_MM_SS as datetime format for ICE dump files
bb943af 
Windows paths do not support `:`, so use a datetime format in ICE dump
paths that Windows will accept.

Fix rust-lang#116809, fix rust-lang#115180.
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 18, 2023
@bors
Auto merge of rust-lang#116814 - estebank:windows-ice-path, r=petroch…
6d7160c 
…enkov

Use `YYYY-MM-DDTHH_MM_SS` as datetime format for ICE dump files

Windows paths do not support `:`, so use a datetime format in ICE dump paths that Windows will accept.

CC rust-lang#116809, fix rust-lang#115180.
@bors bors closed this as completed in e1aa5ad Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@estebank estebank

Labels
C-bug Category: This is a bug. O-windows Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use YYYY-MM-DDTHH_MM_SS as datetime format for ICE dump files estebank/rust
7 participants
@matthiaskrgr @estebank @ChrisDenton @Enet4 @saethlin @Fulgen301 @rustbot