-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't suggest dereferencing on &dyn T where T is a trait #115569
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
typesanitizer
added
A-diagnostics
Area: Messages for errors, warnings, and lints
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Sep 5, 2023
rustbot
added
the
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
label
Sep 5, 2023
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Sep 7, 2023
… r=oli-obk Don't suggest dereferencing to unsized type Rudimentary check that the self type is Sized. I don't really like any of this diagnostics code -- it's really messy and also really prone to false positives and negatives, but oh well. Fixes rust-lang#115569
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Sep 7, 2023
… r=oli-obk Don't suggest dereferencing to unsized type Rudimentary check that the self type is Sized. I don't really like any of this diagnostics code -- it's really messy and also really prone to false positives and negatives, but oh well. Fixes rust-lang#115569
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Sep 7, 2023
… r=oli-obk Don't suggest dereferencing to unsized type Rudimentary check that the self type is Sized. I don't really like any of this diagnostics code -- it's really messy and also really prone to false positives and negatives, but oh well. Fixes rust-lang#115569
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Sep 8, 2023
Rollup merge of rust-lang#115629 - compiler-errors:sugg-deref-unsize, r=oli-obk Don't suggest dereferencing to unsized type Rudimentary check that the self type is Sized. I don't really like any of this diagnostics code -- it's really messy and also really prone to false positives and negatives, but oh well. Fixes rust-lang#115569
fmease
removed
the
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
label
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Code
Rationale and extra context
No response
Other cases
No response
Anything else?
Playground link: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=84f3066368cc498af5c078514f84525a
The text was updated successfully, but these errors were encountered: