Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private traits can be implemented cross-crate #11593

Closed
sfackler opened this issue Jan 16, 2014 · 2 comments · Fixed by #11628
Closed

Private traits can be implemented cross-crate #11593

sfackler opened this issue Jan 16, 2014 · 2 comments · Fixed by #11628

Comments

@sfackler
Copy link
Member

This should not compile but it does.

test.rs:

trait Foo {
    fn foo();
}

test2.rs:

extern mod test;

struct Bar;

impl test::Foo for Bar {
    fn foo() {}
}
@sfackler
Copy link
Member Author

cc @alexcrichton

@alexcrichton
Copy link
Member

That's bad.

@alexcrichton alexcrichton mentioned this issue Jan 17, 2014
Merged
bors added a commit that referenced this issue Jan 19, 2014
@bors
auto merge of #11628 : alexcrichton/rust/issue-11593, r=brson
6d58c70 
Turns out we were just forgetting to encode the privacy for trais, and
everything without privacy defaults to public!

Closes #11593
flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 6, 2023
@bors
Auto merge of rust-lang#11593 - koka831:fix/10511, r=xFrednet
aee3daf 
Use Span#from_expansion instead of in_external_macro

- fixes rust-lang#10511

I checked [the reported repository](rust-lang/rust-clippy#10511 (comment)) and found that clippy hangs at [py_sync.rs#L85](https://github.com/rigetti/qcs-sdk-rust/blob/842094068ed6174ba08b52a2fbae39dda77cbd00/crates/python/src/py_sync.rs#L85), where a macro(`py_function_sync_async`) defines type parameters. this macro is used in the same crate, so `in_external_macro` wouldn't catch them.

This PR fixes the problem by using `Span#from_expansion`.

---

changelog: ICE: [`implicit_hasher`]: No longer lints inside macros, which could cause ICEs
[rust-lang#11593](rust-lang/rust-clippy#11593)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disallow implementation of cross-crate priv traits alexcrichton/rust
2 participants
@alexcrichton @sfackler