unknown unstable option: `ignore-directory-in-diagnostics-source-blocks`

[m-ou-se]

When I run ./x.py test locally, I get errors:

---- [ui] tests/ui-fulldeps/session-diagnostic/invalid-variable.rs stdout ----

error: test compilation failed although it shouldn't!
[..]
--- stderr -------------------------------
error: unknown unstable option: `ignore-directory-in-diagnostics-source-blocks`
------------------------------------------

(Same for 27 ui-fulldeps tests in total.)

I assume this happened after #115869. cc @pietroalbini

[m-ou-se]

Since CI isn't running into these issues, I'm guessing it only happens with --stage=1 and works fine with --stage=2.

[m-ou-se]

Yup, it works fine with ./x.py test --stage=2 here.

[compiler-errors]

Ugh, this keeps happening to ui-fulldeps when we add new -Z flags.

[compiler-errors]

#114482 #114102

I think we should just test ui-fulldeps --stage=1 in CI to make sure this doesn't keep happening. See the description of #114102 to understand why ui-fulldeps actually builds with stage0, which means that modifications to the UI test code adding new flags need to make sure they're properly gating their code.

[compiler-errors]

Either that, or we need something like -Zignore-missing-flags and pass that just to the ui-fulldeps suite on stage1. That seems more like a hack though :s

[Mark-Simulacrum]

@compiler-errors https://github.com/rust-lang/rust/blob/master/src/ci/docker/host-x86_64/x86_64-gnu-llvm-15/script.sh#L6 should be pretty easy to extend with a --stage=1 for ui-fulldeps.

[compiler-errors]

Cool, will do when I get home.