-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-parallel-compilerArea: parallel compilerArea: parallel compilerI-slowIssue: Problems and improvements with respect to performance of generated code.Issue: Problems and improvements with respect to performance of generated code.S-blockedStatus: Blocked on something else such as an RFC or other implementation work.Status: Blocked on something else such as an RFC or other implementation work.
Description
This does look at bit expensive. It's probably a good idea to measure the performance impact of it. It might be a better idea to write the error to a mutex / atomic instead.
Originally posted by @Zoxc in #116849 (comment)
Once we have enabled parallel-compiler by default, we can run multithreaded benchmarks of the current impl against an impl that instead writes to an AtomicBool
(as Result<(), ErrorGuaranteed>
is effectively just a bool)
Metadata
Metadata
Assignees
Labels
A-parallel-compilerArea: parallel compilerArea: parallel compilerI-slowIssue: Problems and improvements with respect to performance of generated code.Issue: Problems and improvements with respect to performance of generated code.S-blockedStatus: Blocked on something else such as an RFC or other implementation work.Status: Blocked on something else such as an RFC or other implementation work.