Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc sidebar links are broken #117290

Closed
epage opened this issue Oct 27, 2023 · 1 comment · Fixed by #117864
Closed

rustdoc sidebar links are broken #117290

epage opened this issue Oct 27, 2023 · 1 comment · Fixed by #117864
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@epage
Copy link
Contributor

epage commented Oct 27, 2023

Browse toml_edit::visit for v0.20.6

I expected to see this happen: Click on module links in side bar, they work

Instead, this happened: Click on module links in side bar and they don't work

Meta

rustc --version --verbose:

rustc 1.75.0-nightly (aa1a71e9e 2023-10-26)

See https://docs.rs/crate/toml_edit/0.20.6/builds/951451
@epage epage added the C-bug Category: This is a bug. label Oct 27, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 27, 2023
@saethlin saethlin added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Oct 28, 2023
@BatmanAoD
Copy link
Member

I notice that the URLs seem to be concatenating the chosen ToC item with whatever item the user is currently looking at.

@epage epage mentioned this issue Nov 6, 2023
Closed
2 tasks
@notriddle notriddle mentioned this issue Nov 13, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 13, 2023
@bors
Auto merge of rust-lang#117864 - notriddle:notriddle/rustdoc-root, r=…
891c6ee 
…GuillaumeGomez

rustdoc: use `.rustdoc` class instead of `body`

This didn't show up in our local tests, because the problem is actually caused by docs.rs rewritten HTML (which relocates the classes that this code looked for from the body tag to a child div).

Fixes rust-lang#117290

r? `@GuillaumeGomez`

Both problems are regressions introduced by rust-lang#115948
@bors bors closed this as completed in 8b1bcc8 Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: use .rustdoc class instead of body notriddle/rust
4 participants
@epage @BatmanAoD @saethlin @rustbot