-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap: Build compiler crates that ought to compile on stable without RUSTC_BOOTSTRAP=1
#117937
Comments
FWIW, there is already the |
And we have |
Seems like this note was added in #26417, when use of unstable features was turned into a compiler error rather than a lint |
Okay, I guess I'm gonna submit a t-lang-nominated PR later undeprecating |
…tc-crates, r=WaffleLapkin Undeprecate lint `unstable_features` and make use of it in the compiler See also rust-lang#117937. r? compiler
…tc-crates, r=WaffleLapkin Undeprecate lint `unstable_features` and make use of it in the compiler See also rust-lang#117937. r? compiler
…tc-crates, r=WaffleLapkin Undeprecate lint `unstable_features` and make use of it in the compiler See also rust-lang#117937. r? compiler
…tc-crates, r=WaffleLapkin Undeprecate lint `unstable_features` and make use of it in the compiler See also rust-lang#117937. r? compiler
Rollup merge of rust-lang#118639 - fmease:deny-features-in-stable-rustc-crates, r=WaffleLapkin Undeprecate lint `unstable_features` and make use of it in the compiler See also rust-lang#117937. r? compiler
Uplifted from #117819 (comment).
There exist some compiler crates (e.g.,
rustc_lexer
andrustc_parse_format
) which ought not use unstable features since they are used by other tools like rust-analyzer which has a “no nightly” policy. The aforementioned crates do contain comments informing rustc devs about it, they are easy to miss however.If bootstrap were to compile those crates without
RUSTC_BOOTSTRAP=1
, the issue of PRs accidentally adding#![feature]
s to such crates could be prevented in the future.Alternative: A rustc-internal or regular lint triggering on
#![feature]
s.The text was updated successfully, but these errors were encountered: