libnative does not close port cleanly under some circumstances

[derekchiang]

Machine: Ubuntu 13.10, 64-bit

rustc version: 0.10-pre (master)

Steps to reproduce:

1. Compile this code:

extern mod native;

use std::io::{io_error, Listener, Acceptor};
use std::io::net::ip::SocketAddr;
use std::io::net::tcp::{TcpListener};

#[start]
fn start(argc: int, argv: **u8) -> int {
    do native::start(argc, argv) {
        let mut acceptor = match TcpListener::bind(
            from_str::<SocketAddr>("127.0.0.1:8021").unwrap()).listen() {
            None => {
                error!("bind or listen failed :-(");
                return;
            },
            Some(acceptor) => acceptor,
        };

        let mut error = None;
        io_error::cond.trap(|e| {
            error = Some(e);
        }).inside(|| {
            println!("Visit http://127.0.0.1:8021");
            acceptor.accept();
            println!("Got a stream!");
        });
    }
}

1. Run the executable.
2. Visit http://127.0.0.1:8021 in a browser (the program will terminate).
3. Run the executable again.

Now you should see a task failure like this:

task '<unnamed>' failed at 'Unhandled condition: io_error: io::IoError{kind: ConnectionRefused, desc: "address in use", detail: Some(~"Address already in use")}', /build/buildd/rust-nightly-201401260405~897a0a3~saucy/src/libstd/condition.rs:139

[derekchiang]

Strangely though, if instead of using a browser you use curl, the problem doesn't happen.

[bnoordhuis]

I think #11845 addresses this?

[alexcrichton]

I would guess that #11845 is the fix, I'll test manually once it's merged.

[thestinger]

Shouldn't it be calling shutdown regardless of whether it plans on reusing the port? I don't think SO_REUSEADDR if fixing the issue, just masking it.

[bnoordhuis]

@thestinger shutdown() on a listen socket returns ENOTCONN. The issue here is the two minute grace time (or whatever the platform default is) for TCP ports.

[alexcrichton]

Confirmed closed by #11845, thanks @xales!