Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a stable release of LLVM #11849

Closed
brson opened this issue Jan 27, 2014 · 6 comments
Closed

Use a stable release of LLVM #11849

brson opened this issue Jan 27, 2014 · 6 comments
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. P-medium Medium priority

Comments

@brson
Copy link
Contributor

brson commented Jan 27, 2014

Requires #4259. Nominating. Do we want to be able to claim this for 1.0?
@pnkfelix
Copy link
Member

(leaving to team mtg...)

@brson
Copy link
Contributor Author

brson commented Feb 2, 2014

This doesn't necessarily mean upstreaming all our patches as long as Rust can be built with a stable release of LLVM.

@flaper87
Copy link
Contributor

flaper87 commented Feb 2, 2014

As a reminder taken from some comments in #4259, this specific issue is quite important for packaging. For instance, it won't be possible to upload a Rust package to fedora repos unless we start using stable llvm releases.

@flaper87
Copy link
Contributor

flaper87 commented Feb 2, 2014

FWIW, I gave it a try and it doesn't compile with stable llvm (version 3.4). When my queue of things to do gets shorter, I could give this a try (unless someone wants to start playing with this right away)

@flaper87
Copy link
Contributor

I believe this is done. We've been using upstream llvm 3.3 and 3.4 (Now upgrading to 3.5 #13513) for our travis builds. I'll leave the close call to @alexcrichton who has been working heavily on this area.

@alexcrichton
Copy link
Member

Hurray! Yes, we will be fully compatible with 3.5 by the time it comes out.

bors added a commit to rust-lang-ci/rust that referenced this issue Dec 1, 2023
@bors
Auto merge of rust-lang#11849 - GuillaumeGomez:add-more-transmute_ref…
b21c9d4 
…_to_ref-tests, r=blyxyas

Add tests for issues rust-lang#10285, rust-lang#10286, rust-lang#10289, rust-lang#10287

Fixes rust-lang#10285.
Fixes rust-lang#10286.
Fixes rust-lang#10289.
Fixes rust-lang#10287.

This PR simply adds tests for the listed issues as they're already implemented so we can close them.

r? `@blyxyas`

changelog:none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. P-medium Medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@flaper87 @alexcrichton @brson @pnkfelix