Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustpkg can't find std and extra #11852

Closed
eholk opened this issue Jan 27, 2014 · 5 comments · Fixed by #11963
Closed

rustpkg can't find std and extra #11852

eholk opened this issue Jan 27, 2014 · 5 comments · Fixed by #11963

Comments

@eholk
Copy link
Contributor

eholk commented Jan 27, 2014

A couple of days ago, some of my Rust CI builds started failing because rustpkg is having trouble finding std and extra.

Here are a couple of failed builds:
@olsonjeffery
Copy link
Contributor

extern mod extra = "extra#0.10.pre"; , etc.. this is kind of an obnoxious and unexpected change. the concensus, on #rust, seems to be "flee to cargo-lite!" :/

@metajack
Copy link
Contributor

Is this a case of rust using rlibs by default and rustpkg not looking for them? Or was that fixed?

Though even in that case I can't imagine why adding version info would cause it to start working. The version info just filters out candidates, or at least that was my understanding.

@eholk
Copy link
Contributor Author

eholk commented Jan 28, 2014

I tried adding the version information last night and it didn't seem to help...

@nielsle
Copy link
Contributor

nielsle commented Jan 28, 2014

Just for reference: You also have to add version information to test.rs. (I didn't test your code, but changing test.rs solved a similar problem for me)

@alexcrichton alexcrichton mentioned this issue Jan 31, 2014
Merged
bors added a commit that referenced this issue Feb 1, 2014
@bors
auto merge of #11963 : alexcrichton/rust/fix-rustpkg, r=brson
c80d28c 
Right now the bots are all injecting a libstd version, so all the rustpkg tests
are passing. All rustpkg compilations will fail unless the version number is
explicitly given because rustpkg attempts to exactly guess the target file name.
Switch back to using a pattern match in order to unbreak tests.

Closes #11852
@eholk
Copy link
Contributor Author

eholk commented Feb 6, 2014

It seems like rustpkg is being/was removed, so this bug is sort of irrelevant now.

flip1995 pushed a commit to flip1995/rust that referenced this issue May 2, 2024
@bors
Auto merge of rust-lang#11852 - rust-lang:single-char-pattern-ascii-o…
fc6dfeb 
…nly, r=xFrednet

reduce `single_char_pattern` to only lint on ascii chars

This should mostly fix the `single_char_pattern` lint, because with a single byte, the optimizer will usually see through the char-to-string-expansion and single loop iteration. This fixes rust-lang#11675 and rust-lang#8111.

Update: As per the meeting on November 28th, 2023, we voted to also downgrade the lint to pedantic.

---

changelog: downgrade [`single_char_pattern`] to `pedantic`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix rustpkg tests with --disable-inject-std-version alexcrichton/rust
4 participants
@olsonjeffery @metajack @eholk @nielsle