Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

methods of re-exported private items are not placed in the search index #11943

Closed
SiegeLord opened this issue Jan 30, 2014 · 2 comments
Closed
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@SiegeLord
Copy link
Contributor

E.g. take this crate:

#[crate_id="test"];

pub use private::Foo;

mod private
{
    pub struct Foo;
    impl Foo
    {
        pub fn test_method() {}
    }
}

After generating the documentation with it, you cannot search for the test_method method. This can be manually verified by grepping for it in the doc/test/search-index.js file.

@emberian
Copy link
Member

Still a bug.

SiegeLord added a commit to SiegeLord/rust that referenced this issue Aug 26, 2014
…in a private module.

Previously, this caused methods of re-exported types to not be inserted into
the search index. This fix may introduce some false positives, but in my
testing they appear as orphaned methods and end up not being inserted into the
final search index at a later stage.

Fixes issue rust-lang#11943
bors added a commit that referenced this issue Aug 29, 2014
Previously, this caused methods of re-exported types to not be inserted into
the search index. This fix may introduce some false positives, but in my
testing they appear as orphaned methods and end up not being inserted into the
final search index at a later stage.

Fixes issue #11943
@steveklabnik
Copy link
Member

#16767 was merged, so i'm giving this a close.

flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 16, 2023
…r=Jarcho

Check $CARGO before $PATH

Currently, clippy will ignore $CARGO when spawning cargo commands, which can be problematic for `cargo clippy` and interop with other tools. This commit induces clippy to respect $CARGO in every case it seems likely to matter.

Fixes:
- rust-lang#11943

changelog: clippy now respects setting the `CARGO` environment variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants