-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make unsafe_op_in_unsafe_fn
auto-migrated in 2024 edition
#119823
Labels
A-edition-2024
Area: The 2024 edition
A-lint
Area: Lints (warnings about flaws in source code) such as unused_mut.
C-bug
Category: This is a bug.
E-help-wanted
Call for participation: Help is requested to fix this issue.
F-unsafe-block-in-unsafe-fn
RFC #2585
Comments
rustbot
added
the
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
label
Jan 10, 2024
tmandry
added
A-lint
Area: Lints (warnings about flaws in source code) such as unused_mut.
E-help-wanted
Call for participation: Help is requested to fix this issue.
C-bug
Category: This is a bug.
F-unsafe-block-in-unsafe-fn
RFC #2585
A-edition-2024
Area: The 2024 edition
and removed
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
labels
Jan 10, 2024
@rustbot claim |
5 tasks
TaKO8Ki
added a commit
to TaKO8Ki/rust
that referenced
this issue
Jan 21, 2024
…fn_fix, r=TaKO8Ki Make `unsafe_op_in_unsafe_fn` migrated in edition 2024 fixes rust-lang#119823
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jan 22, 2024
…fn_fix, r=TaKO8Ki Make `unsafe_op_in_unsafe_fn` migrated in edition 2024 fixes rust-lang#119823
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jan 22, 2024
…fn_fix, r=TaKO8Ki Make `unsafe_op_in_unsafe_fn` migrated in edition 2024 fixes rust-lang#119823
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jan 22, 2024
Rollup merge of rust-lang#119948 - asquared31415:unsafe_op_in_unsafe_fn_fix, r=TaKO8Ki Make `unsafe_op_in_unsafe_fn` migrated in edition 2024 fixes rust-lang#119823
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-edition-2024
Area: The 2024 edition
A-lint
Area: Lints (warnings about flaws in source code) such as unused_mut.
C-bug
Category: This is a bug.
E-help-wanted
Call for participation: Help is requested to fix this issue.
F-unsafe-block-in-unsafe-fn
RFC #2585
There are two things to do:
Applicability
toMachineApplicable
.FutureIncompatibilityReason::EditionError
orFutureIncompatibilityReason::EditionSemanticsChange
can do that. It sounds like that is not what you want to do (make it a hard error), so there will need to be new code to handle this scenario.That's not the only reason for future-incompatible lints. There are different categories, such as warning in dependencies (for soundness fixes), and for edition migrations (which don't warn in dependencies, only in the
cargo fix --edition
automatic migration). I opened #117927 to try to document it a little more clearly.Unfortunately the current system doesn't support the use case it sounds like you want (where it is only a warning in the new edition). It should be a relatively simple case of introducing something that will add the lint to the
rust-2024-compatibility
lint group.Yea, that's the problem I'm trying to bring up. This lint currently is not in the
rust-2024-compatibility
lint group which is required for handling that.Originally posted by @ehuss in #112038 (comment)
The text was updated successfully, but these errors were encountered: