-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Consider linting against 00B7 aka interpunct aka middle dot #120797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think this is a T-lang issue to decide, not a T-compiler one. @rustbot label: +T-lang -T-compiler |
Also I think its one that the Lang team might be able to resolve quickly, so I'm nominating for discussion at the T-lang triage meeting. @rustbot label: I-lang-nominated |
While we are at it, I think it could also make sense to lint against U+30FB KATAKANA MIDDLE DOT as mentioned here. MIDDLE DOT and KATAKANA MIDDLE DOT are the only two |
I'd be extremely hesitant to set any precedent of adding language-specific linting rules (e.g. only allowing this character between two |
I think it's fine as long as we're reusing existing lint names. We don't make any guarantees about lints generally. It's seems more like a matter of how much code does the compiler team want to maintain. |
Based on discussion in today's @rust-lang/lang meeting, proposing that we not do this in uncommon_codepoints, and that we consider this again after we have the split-out lint that @Manishearth suggests in point 1 of #120228 (a lint about confusables with operator/punctuation). @rfcbot postpone |
Team member @joshtriplett has proposed to postpone this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns. |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to postpone, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. |
@rustbot labels -I-lang-nominated This has completed FCP with a disposition to postpone, so let's unnominate. |
Code
Current output
but note that visual of the first line is font-dependent, in terms of how the columns of a fixed-width font line up; the playpen collapses the L·L into a single glyph that occupies one character width.
Desired output
I'm not certain. I just want to make sure we follow-up on PR #120695
The options I see are either:
uncommon_codepoints
: lint against 00B7 MIDDLE DOT in final position #120695: continue hard-rejecting 00B7 as an initial character; lint against its occurrence as a final character, and silently accept it as a "medial" characteruncommon_codepoints
: lint against 00B7 MIDDLE DOT in final position #120695, like linting against 00B7 in all contexts (except perhaps when it occurs in between two L's, to accommodate Catalan, as suggested by Manish here)Rationale and extra context
No response
Other cases
No response
Rust Version
Anything else?
No response
The text was updated successfully, but these errors were encountered: