Skip to content

io::net::unix needs to be renamed #12093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexcrichton opened this issue Feb 7, 2014 · 0 comments · Fixed by #17297
Closed

io::net::unix needs to be renamed #12093

alexcrichton opened this issue Feb 7, 2014 · 0 comments · Fixed by #17297

Comments

@alexcrichton
Copy link
Member

Right now, it's got cfg(unix), so then name "unix pipes" makes sense. The librustuv implementation supports windows named pipes, and the libnative implementation will soon also support named pipes.

This should probably be renamed to io::pipe or io::net::pipe (or something like that).
@alexcrichton alexcrichton mentioned this issue Feb 8, 2014
Merged
bors added a commit that referenced this issue Feb 18, 2014
@bors
auto merge of #12103 : alexcrichton/rust/unix, r=brson
62d7d00 
There's a few parts to this PR

* Implement unix pipes in libnative for unix platforms (thanks @Geal!)
* Implement named pipes in libnative for windows (terrible, terrible code)
* Remove `#[cfg(unix)]` from `mod unix` in `std::io::net`. This is a terrible name for what it is, but that's the topic of #12093.

The windows implementation was significantly more complicated than I thought it would be, but it seems to be passing all the tests. now.

Closes #11201
@treeman treeman mentioned this issue Sep 16, 2014
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
@bors
Auto merge of rust-lang#12093 - nico-abram:uwu, r=Veykril
9e10d4b 
Reload project on .cargo/config[.toml] changes

Fixes rust-lang#11024

Not adding tests as discussed in the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename std::io::net::unix to std::io::net::pipe.
1 participant
@alexcrichton