Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICE: Anonymous structs or unions cannot be type parameters #121299

Closed
matthiaskrgr opened this issue Feb 19, 2024 · 3 comments · Fixed by #131045
Closed

ICE: Anonymous structs or unions cannot be type parameters #121299

matthiaskrgr opened this issue Feb 19, 2024 · 3 comments · Fixed by #131045
Labels
C-bug Category: This is a bug. F-unnamed_fields `#![feature(unnamed_fields)]` I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. S-bug-has-test Status: This bug is tracked inside the repo by a `known-bug` test. S-has-mcve Status: A Minimal Complete and Verifiable Example has been found for this issue T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@matthiaskrgr
Copy link
Member

snippet:

#[derive(Eq)]
struct D {
    _: union {
    },
}

Version information

rustc 1.78.0-nightly (bea5bebf3 2024-02-19)
binary: rustc
commit-hash: bea5bebf3defc56e5e3446b4a95c685dbb885fd3
commit-date: 2024-02-19
host: x86_64-unknown-linux-gnu
release: 1.78.0-nightly
LLVM version: 18.1.0

Command:
/home/matthias/.rustup/toolchains/master/bin/rustc

Program output 

thread 'rustc' panicked at compiler/rustc_builtin_macros/src/deriving/mod.rs:127:5:
Anonymous structs or unions cannot be type parameters
stack backtrace:
   0:     0x7f36a6c70b56 - std::backtrace_rs::backtrace::libunwind::trace::h3a158c8f16516afb
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/std/src/../../backtrace/src/backtrace/libunwind.rs:104:5
   1:     0x7f36a6c70b56 - std::backtrace_rs::backtrace::trace_unsynchronized::ha89664cca04bb36e
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
   2:     0x7f36a6c70b56 - std::sys_common::backtrace::_print_fmt::h03800d086403b62e
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/std/src/sys_common/backtrace.rs:68:5
   3:     0x7f36a6c70b56 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h91d502aabce8c547
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/std/src/sys_common/backtrace.rs:44:22
   4:     0x7f36a6cc1b0c - core::fmt::rt::Argument::fmt::h99a2d1e221afec6c
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/core/src/fmt/rt.rs:142:9
   5:     0x7f36a6cc1b0c - core::fmt::write::h97a5ad4b86c9e005
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/core/src/fmt/mod.rs:1120:17
   6:     0x7f36a6c654bf - std::io::Write::write_fmt::h2b40f89315aa23ff
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/std/src/io/mod.rs:1846:15
   7:     0x7f36a6c70904 - std::sys_common::backtrace::_print::h4787d964e00e361c
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/std/src/sys_common/backtrace.rs:47:5
   8:     0x7f36a6c70904 - std::sys_common::backtrace::print::hbf94f54b49f22c72
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/std/src/sys_common/backtrace.rs:34:9
   9:     0x7f36a6c7364b - std::panicking::default_hook::{{closure}}::h09f29dc972c775e7
  10:     0x7f36a6c73399 - std::panicking::default_hook::hdb43b973c97e30a9
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/std/src/panicking.rs:292:9
  11:     0x7f36a3a2c5cc - std[e3016e56fde417e8]::panicking::update_hook::<alloc[26f96968629a1477]::boxed::Box<rustc_driver_impl[1d2aada9a967b964]::install_ice_hook::{closure#0}>>::{closure#0}
  12:     0x7f36a6c73db0 - <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call::h7d80339b83881141
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/alloc/src/boxed.rs:2030:9
  13:     0x7f36a6c73db0 - std::panicking::rust_panic_with_hook::ha4f031997107b610
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/std/src/panicking.rs:786:13
  14:     0x7f36a6c73ab9 - std::panicking::begin_panic_handler::{{closure}}::h556d855f34b40d5b
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/std/src/panicking.rs:652:13
  15:     0x7f36a6c71036 - std::sys_common::backtrace::__rust_end_short_backtrace::hcfcfe13416eb9e24
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/std/src/sys_common/backtrace.rs:171:18
  16:     0x7f36a6c73824 - rust_begin_unwind
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/std/src/panicking.rs:648:5
  17:     0x7f36a6cbe015 - core::panicking::panic_fmt::h817e0acf16f85c30
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/core/src/panicking.rs:72:14
  18:     0x7f36a57ea1dc - rustc_builtin_macros[20656e6096520b61]::deriving::assert_ty_bounds
  19:     0x7f36a57e8d7a - rustc_builtin_macros[20656e6096520b61]::deriving::eq::expand_deriving_eq::{closure#0}
  20:     0x7f36a54ac3cc - <rustc_builtin_macros[20656e6096520b61]::deriving::generic::TraitDef>::expand_struct_def
  21:     0x7f36a57e5011 - <rustc_builtin_macros[20656e6096520b61]::deriving::generic::TraitDef>::expand_ext
  22:     0x7f36a5875d17 - rustc_builtin_macros[20656e6096520b61]::deriving::eq::expand_deriving_eq
  23:     0x7f36a54aa052 - <rustc_builtin_macros[20656e6096520b61]::deriving::BuiltinDerive as rustc_expand[a0d1a98eef577773]::base::MultiItemModifier>::expand
  24:     0x7f36a55b8447 - <rustc_expand[a0d1a98eef577773]::expand::MacroExpander>::fully_expand_fragment
  25:     0x7f36a55b5ef7 - <rustc_expand[a0d1a98eef577773]::expand::MacroExpander>::expand_crate
  26:     0x7f36a5ad0092 - rustc_interface[37c35c6dbc63475a]::passes::resolver_for_lowering
  27:     0x7f36a5acf567 - rustc_query_impl[2d5ef8d54471ac61]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[2d5ef8d54471ac61]::query_impl::resolver_for_lowering::dynamic_query::{closure#2}::{closure#0}, rustc_middle[3a9dcbdbfc28ae03]::query::erase::Erased<[u8; 8usize]>>
  28:     0x7f36a5996e4e - rustc_query_system[1991136b97b46e9d]::query::plumbing::try_execute_query::<rustc_query_impl[2d5ef8d54471ac61]::DynamicConfig<rustc_query_system[1991136b97b46e9d]::query::caches::SingleCache<rustc_middle[3a9dcbdbfc28ae03]::query::erase::Erased<[u8; 8usize]>>, false, false, false>, rustc_query_impl[2d5ef8d54471ac61]::plumbing::QueryCtxt, false>
  29:     0x7f36a59965cb - rustc_query_impl[2d5ef8d54471ac61]::query_impl::resolver_for_lowering::get_query_non_incr::__rust_end_short_backtrace
  30:     0x7f36a595df14 - rustc_interface[37c35c6dbc63475a]::interface::run_compiler::<core[7975d3e35f006c71]::result::Result<(), rustc_span[64c55662242a9f4e]::ErrorGuaranteed>, rustc_driver_impl[1d2aada9a967b964]::run_compiler::{closure#0}>::{closure#0}
  31:     0x7f36a5bbf305 - std[e3016e56fde417e8]::sys_common::backtrace::__rust_begin_short_backtrace::<rustc_interface[37c35c6dbc63475a]::util::run_in_thread_with_globals<rustc_interface[37c35c6dbc63475a]::util::run_in_thread_pool_with_globals<rustc_interface[37c35c6dbc63475a]::interface::run_compiler<core[7975d3e35f006c71]::result::Result<(), rustc_span[64c55662242a9f4e]::ErrorGuaranteed>, rustc_driver_impl[1d2aada9a967b964]::run_compiler::{closure#0}>::{closure#0}, core[7975d3e35f006c71]::result::Result<(), rustc_span[64c55662242a9f4e]::ErrorGuaranteed>>::{closure#0}, core[7975d3e35f006c71]::result::Result<(), rustc_span[64c55662242a9f4e]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[7975d3e35f006c71]::result::Result<(), rustc_span[64c55662242a9f4e]::ErrorGuaranteed>>
  32:     0x7f36a5bbf132 - <<std[e3016e56fde417e8]::thread::Builder>::spawn_unchecked_<rustc_interface[37c35c6dbc63475a]::util::run_in_thread_with_globals<rustc_interface[37c35c6dbc63475a]::util::run_in_thread_pool_with_globals<rustc_interface[37c35c6dbc63475a]::interface::run_compiler<core[7975d3e35f006c71]::result::Result<(), rustc_span[64c55662242a9f4e]::ErrorGuaranteed>, rustc_driver_impl[1d2aada9a967b964]::run_compiler::{closure#0}>::{closure#0}, core[7975d3e35f006c71]::result::Result<(), rustc_span[64c55662242a9f4e]::ErrorGuaranteed>>::{closure#0}, core[7975d3e35f006c71]::result::Result<(), rustc_span[64c55662242a9f4e]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[7975d3e35f006c71]::result::Result<(), rustc_span[64c55662242a9f4e]::ErrorGuaranteed>>::{closure#1} as core[7975d3e35f006c71]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  33:     0x7f36a6c7d785 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::hdf5fa3c582f259ae
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/alloc/src/boxed.rs:2016:9
  34:     0x7f36a6c7d785 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h57a62cffc212fbb2
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/alloc/src/boxed.rs:2016:9
  35:     0x7f36a6c7d785 - std::sys::pal::unix::thread::Thread::new::thread_start::hf5c20164f3984a87
                               at /rustc/bea5bebf3defc56e5e3446b4a95c685dbb885fd3/library/std/src/sys/pal/unix/thread.rs:108:17
  36:     0x7f36a0aaa9eb - <unknown>
  37:     0x7f36a0b2e7cc - <unknown>
  38:                0x0 - <unknown>

error: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md

note: rustc 1.78.0-nightly (bea5bebf3 2024-02-19) running on x86_64-unknown-linux-gnu

query stack during panic:
#0 [resolver_for_lowering] getting the resolver for lowering
end of query stack

@matthiaskrgr matthiaskrgr added I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Feb 19, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 19, 2024
@matthiaskrgr matthiaskrgr changed the title ICE: ´Anonymous structs or unions cannot be type parameters` ICE: `Anonymous structs or unions cannot be type parameters´ Feb 19, 2024
@jieyouxu jieyouxu added S-has-mcve Status: A Minimal Complete and Verifiable Example has been found for this issue F-unnamed_fields `#![feature(unnamed_fields)]` and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Feb 19, 2024
@jieyouxu
Copy link
Member

Doesn't crash on stable, but crashes in nightly in playground (1.78.0-nightly (2024-02-18 2bf78d12d33ae02d1001)).

@jieyouxu jieyouxu added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. and removed F-unnamed_fields `#![feature(unnamed_fields)]` labels Feb 19, 2024
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Feb 19, 2024
@jieyouxu jieyouxu added the F-unnamed_fields `#![feature(unnamed_fields)]` label Feb 19, 2024
@Noratrieb Noratrieb removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Feb 20, 2024
@clubby789
Copy link
Contributor

Should be fixed by #121270

@clubby789 clubby789 mentioned this issue Feb 22, 2024
Closed
@fmease fmease changed the title ICE: `Anonymous structs or unions cannot be type parameters´ ICE: Anonymous structs or unions cannot be type parameters Feb 23, 2024
@matthiaskrgr matthiaskrgr added the S-bug-has-test Status: This bug is tracked inside the repo by a `known-bug` test. label Apr 15, 2024
@lolbinarycat
Copy link
Contributor

triage: still broken in latest nightly

@clubby789 clubby789 mentioned this issue Sep 29, 2024
Closed
@compiler-errors compiler-errors mentioned this issue Sep 30, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 11, 2024
@bors
Auto merge of rust-lang#131045 - compiler-errors:remove-unnamed_field…
80325f2 
…s, r=wesleywiser

Retire the `unnamed_fields` feature for now

`#![feature(unnamed_fields)]` was implemented in part in rust-lang#115131 and rust-lang#115367, however work on that feature has (afaict) stalled and in the mean time there have been some concerns raised (e.g.[^1][^2]) about whether `unnamed_fields` is worthwhile to have in the language, especially in its current desugaring. Because it represents a compiler implementation burden including a new kind of anonymous ADT and additional complication to field selection, and is quite prone to bugs today, I'm choosing to remove the feature.

However, since I'm not one to really write a bunch of words, I'm specifically *not* going to de-RFC this feature. This PR essentially *rolls back* the state of this feature to "RFC accepted but not yet implemented"; however if anyone wants to formally unapprove the RFC from the t-lang side, then please be my guest. I'm just not totally willing to summarize the various language-facing reasons for why this feature is or is not worthwhile, since I'm coming from the compiler side mostly.

Fixes rust-lang#117942
Fixes rust-lang#121161
Fixes rust-lang#121263
Fixes rust-lang#121299
Fixes rust-lang#121722
Fixes rust-lang#121799
Fixes rust-lang#126969
Fixes rust-lang#131041

Tracking:
* rust-lang#49804

[^1]: https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/Unnamed.20struct.2Funion.20fields
[^2]: rust-lang#49804 (comment)
@bors bors closed this as completed in f496659 Oct 11, 2024
flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 18, 2024
@bors
Auto merge of rust-lang#131045 - compiler-errors:remove-unnamed_field…
f5cc292 
…s, r=wesleywiser

Retire the `unnamed_fields` feature for now

`#![feature(unnamed_fields)]` was implemented in part in rust-lang#115131 and rust-lang#115367, however work on that feature has (afaict) stalled and in the mean time there have been some concerns raised (e.g.[^1][^2]) about whether `unnamed_fields` is worthwhile to have in the language, especially in its current desugaring. Because it represents a compiler implementation burden including a new kind of anonymous ADT and additional complication to field selection, and is quite prone to bugs today, I'm choosing to remove the feature.

However, since I'm not one to really write a bunch of words, I'm specifically *not* going to de-RFC this feature. This PR essentially *rolls back* the state of this feature to "RFC accepted but not yet implemented"; however if anyone wants to formally unapprove the RFC from the t-lang side, then please be my guest. I'm just not totally willing to summarize the various language-facing reasons for why this feature is or is not worthwhile, since I'm coming from the compiler side mostly.

Fixes rust-lang#117942
Fixes rust-lang#121161
Fixes rust-lang#121263
Fixes rust-lang#121299
Fixes rust-lang#121722
Fixes rust-lang#121799
Fixes rust-lang#126969
Fixes rust-lang#131041

Tracking:
* rust-lang#49804

[^1]: https://rust-lang.zulipchat.com/#narrow/stream/213817-t-lang/topic/Unnamed.20struct.2Funion.20fields
[^2]: rust-lang#49804 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. F-unnamed_fields `#![feature(unnamed_fields)]` I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. S-bug-has-test Status: This bug is tracked inside the repo by a `known-bug` test. S-has-mcve Status: A Minimal Complete and Verifiable Example has been found for this issue T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
6 participants
@matthiaskrgr @clubby789 @lolbinarycat @jieyouxu @rustbot @Noratrieb