Skip to content

RefCell causes unnecessary code bloat + branches #12198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thestinger opened this issue Feb 11, 2014 · 3 comments
Closed

RefCell causes unnecessary code bloat + branches #12198

thestinger opened this issue Feb 11, 2014 · 3 comments
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@thestinger
Copy link
Contributor

It performs unnecessary assertions at the end of every borrow, and these are never disabled.
@sfackler
Copy link
Member

Should be fixable once #12108 lands. Alternatively, the assertions could just be removed.

@nikomatsakis
Copy link
Contributor

I'd prefer to keep the assertions (but probably compile them out in non-debug builds). Unsafe code should have plenty of assertions, imo. Helps the reader. Helps the refactorer. Helps everybody.

@gereeter
Copy link
Contributor

I believe this was fixed by #13789 and should be closed.

bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
@bors
Auto merge of rust-lang#12198 - jonas-schievink:ide-resolve-supertrai…
ab55805 
…t-assoc-types, r=jonas-schievink

fix: Resolve assoc. types of supertraits in the IDE layer

Fixes rust-lang/rust-analyzer#12166
flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 26, 2024
@bors
Auto merge of rust-lang#12198 - oli-obk:bump_ui_test, r=Manishearth
ab8880b 
Bump ui_test to 0.22

*Please write a short comment explaining your change (or "none" for internal only changes)*

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nikomatsakis @sfackler @thestinger @gereeter