Skip to content

Missing PartialOrd comment for array #122073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
KonradHoeffner opened this issue Mar 6, 2024 · 0 comments
Closed

Missing PartialOrd comment for array #122073

KonradHoeffner opened this issue Mar 6, 2024 · 0 comments
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@KonradHoeffner
Copy link
Contributor

Location

library/core/src/array/mod.rs

Summary

The trait implementation of Ord for arrays is properly commented:

impl<T, const N: usize> Ord for [T; N]
where
T: Ord,

Implements comparison of arrays lexicographically.

However this is missing for PartialOrd:

impl<T, const N: usize> PartialOrd for [T; N]
where
T: PartialOrd,
@KonradHoeffner KonradHoeffner added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Mar 6, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 6, 2024
@KonradHoeffner KonradHoeffner mentioned this issue Mar 6, 2024
Merged
@jieyouxu jieyouxu added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Mar 6, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 6, 2024
@matthiaskrgr
Rollup merge of rust-lang#122074 - KonradHoeffner:patch-2, r=jhpratt

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
f3a619a 
Add missing PartialOrd trait implementation doc for array

Analogously to vectors and slices, this PR documents the lexicographic sorting of PartialOrd as rustdoc comment on the trait implementation of PartialOrd for arrays.
Associated issue: rust-lang#122073.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 6, 2024
@matthiaskrgr
Rollup merge of rust-lang#122074 - KonradHoeffner:patch-2, r=jhpratt

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
6279ef2 
Add missing PartialOrd trait implementation doc for array

Analogously to vectors and slices, this PR documents the lexicographic sorting of PartialOrd as rustdoc comment on the trait implementation of PartialOrd for arrays.
Associated issue: rust-lang#122073.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 7, 2024
@rust-timer
Unrolled build for rust-lang#122074

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
81160b7 
Rollup merge of rust-lang#122074 - KonradHoeffner:patch-2, r=jhpratt

Add missing PartialOrd trait implementation doc for array

Analogously to vectors and slices, this PR documents the lexicographic sorting of PartialOrd as rustdoc comment on the trait implementation of PartialOrd for arrays.
Associated issue: rust-lang#122073.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@KonradHoeffner @jieyouxu @workingjubilee @rustbot