You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Which special cases emit_seq for u8's. Msgpack for example support both binaries and sequences of values, while sequences of values incur more overhead because it needs to encode the elements type for each element.
Right now it is not possible to efficiently emit binary type, like type bin = ~[u8] using the Encoder trait. With this change it would be possible. Orthogonally a read_binary() should be added to the Decoder trait, but it is not that important, as read_seq can be overloaded accordingly to read both binaries or sequences.
The default behaviour of emit_binary() could be made to emit a sequence, so almost no code need to be changed.
The text was updated successfully, but these errors were encountered:
[`case_sensitive_file_extension_comparisons`]: Don't trigger on digits-only extensions
If we find a file extension check with only digits (`.123`), do not trigger `case_sensitive_file_extension_comparisons`.
Fixesrust-lang#12252
---
*Please write a short comment explaining your change (or "none" for internal only changes)*
changelog: [`case_sensitive_file_extension_comparisons`]: Don't trigger on digits-only extensions
My proposal is to extend trait
serialize::Encoder
with:Which special cases
emit_seq
foru8
's. Msgpack for example support both binaries and sequences of values, while sequences of values incur more overhead because it needs to encode the elements type for each element.Right now it is not possible to efficiently emit binary type, like
type bin = ~[u8]
using the Encoder trait. With this change it would be possible. Orthogonally a read_binary() should be added to the Decoder trait, but it is not that important, as read_seq can be overloaded accordingly to read both binaries or sequences.The default behaviour of emit_binary() could be made to emit a sequence, so almost no code need to be changed.
The text was updated successfully, but these errors were encountered: