Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make check failes with -g #12333

Closed
nrc opened this issue Feb 17, 2014 · 2 comments · Fixed by #12399
Closed

make check failes with -g #12333

nrc opened this issue Feb 17, 2014 · 2 comments · Fixed by #12399
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.)

Comments

@nrc
Copy link
Member

nrc commented Feb 17, 2014

export RUSTFLAGS=-g
make check

Fails with a whole bunch of errors, e.g.,

@nrc
Copy link
Member Author

nrc commented Feb 17, 2014

(er, whoops, didn't mean to hit 'go' quite so prematurely)

error: compilation failed!
command: x86_64-unknown-linux-gnu/stage2/bin/rustc /home/nick/rust/src/test/run-pass/simd-generics.rs -L x86_64-unknown-linux-gnu/test/run-pass --target=x86_64-unknown-linux-gnu -L x86_64-unknown-linux-gnu/test/run-pass/simd-generics.stage2-x86_64-unknown-linux-gnu.libaux -o x86_64-unknown-linux-gnu/test/run-pass/simd-generics.stage2-x86_64-unknown-linux-gnu -g --cfg rtopt --cfg debug -C prefer-dynamic -O -L x86_64-unknown-linux-gnu/rt

rustc: /home/nick/rust/src/llvm/include/llvm/Support/Casting.h:240: typename llvm::cast_retty<X, Y*>::ret_type llvm::cast(Y*) [with X = llvm::StructType; Y = llvm::Type; typename llvm::cast_retty<X, Y*>::ret_type = llvm::StructType*]: Assertion `isa<X>(Val) && "cast<Ty>() argument of incompatible type!"' failed.

See also #12191 for an error when I tried to do this previously.

@michaelwoerister
Copy link
Member

I was just able to reproduce this. Seems to be related to simd types. I'll look into it some more...

@bors bors closed this as completed in 5f324aa Feb 20, 2014
bors pushed a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
Order auto-imports by relevance

Fixes rust-lang#10337.

Basically we sort the imports according to how "far away" the imported item is from where we want to import it to. This change makes it so that imports from the current crate are sorted before any third-party crates. Additionally, we make an exception for builtin crates (`std`, `core`, etc.) so that they are sorted before any third-party crates.

There are probably other heuristics that should be added to improve the experience (such as preferring imports that are common elsewhere in the same crate, and ranking crates depending on the dependency graph). However, I think this is a first good step.

PS. This is my first time contributing here, so please be gentle if I have missed something obvious :-)
flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 26, 2024
Allow unused_imports, and unused_import_braces on `use`

Fixes rust-lang/rust-clippy#12223.

Both `unused_import_braces` and `unused_imports` are valid on `use`-items, additional to the two previously allowed.

changelog: [`useless_attribute`]: Allow `rustc_lint` `unused_import_braces` and `unused_imports` on `use`-items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants