Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for RFC 3621: derive(SmartPtr) #123430

Open
1 of 6 tasks
traviscross opened this issue Apr 3, 2024 · 2 comments
Open
1 of 6 tasks

Tracking issue for RFC 3621: derive(SmartPtr) #123430

traviscross opened this issue Apr 3, 2024 · 2 comments
Labels
B-experimental Blocker: In-tree experiment; RFC pending, not yet approved or unneeded. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. F-derive_smart_pointer `#![feature(derive_smart_pointer)]` S-tracking-impl-incomplete Status: The implementation is incomplete. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@traviscross
Copy link
Contributor

traviscross commented Apr 3, 2024

This is a tracking issue for #[derive(UnsizeInner)] (formerly known an #[derive(SmartPtr)] / #[derive(SmartPointer)]. The feature gate for the issue is #![feature(derive_smart_pointer)].

About tracking issues

Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

Related

@traviscross traviscross added C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Apr 3, 2024
@traviscross traviscross changed the title Tracking Issue for derive(SmartPtr) Tracking Issue for derive(SmartPointer) Apr 3, 2024
@fmease fmease added B-experimental Blocker: In-tree experiment; RFC pending, not yet approved or unneeded. S-tracking-unimplemented Status: The feature has not been implemented. labels Apr 3, 2024
wedsonaf added a commit to wedsonaf/rust that referenced this issue Apr 4, 2024
@traviscross traviscross added the F-derive_smart_pointer `#![feature(derive_smart_pointer)]` label Apr 4, 2024
wedsonaf added a commit to wedsonaf/rust that referenced this issue Apr 11, 2024
@traviscross traviscross added S-tracking-impl-incomplete Status: The implementation is incomplete. and removed S-tracking-unimplemented Status: The feature has not been implemented. labels May 27, 2024
compiler-errors added a commit to compiler-errors/rust that referenced this issue Jun 24, 2024
… r=davidtwco

SmartPointer derive-macro

<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r​? <reviewer name>
-->

Possibly replacing rust-lang#123472 for continued upkeep of the proposal rust-lang/rfcs#3621 and implementation of the tracking issue rust-lang#123430.

cc `@Darksonn` `@wedsonaf`
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jun 24, 2024
Rollup merge of rust-lang#125575 - dingxiangfei2009:derive-smart-ptr, r=davidtwco

SmartPointer derive-macro

<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r​? <reviewer name>
-->

Possibly replacing rust-lang#123472 for continued upkeep of the proposal rust-lang/rfcs#3621 and implementation of the tracking issue rust-lang#123430.

cc `@Darksonn` `@wedsonaf`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jul 4, 2024
…arent, r=davidtwco

Reject SmartPointer constructions not serving the purpose

Tracking issue: rust-lang#123430

With this PR we will reject a row of malformed `SmartPointer` implementor candidates.

cc `@Darksonn` `@davidtwco` for context.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jul 4, 2024
Rollup merge of rust-lang#127283 - dingxiangfei2009:check-repr-transparent, r=davidtwco

Reject SmartPointer constructions not serving the purpose

Tracking issue: rust-lang#123430

With this PR we will reject a row of malformed `SmartPointer` implementor candidates.

cc `@Darksonn` `@davidtwco` for context.
@Kixunil

This comment was marked as resolved.

@traviscross
Copy link
Contributor Author

@Kixunil: If you could, please file that as a separate issue (and reference this tracking issue from it).

@traviscross traviscross changed the title Tracking Issue for derive(SmartPointer) Tracking Issue for derive(UnsizeInner) Oct 2, 2024
@traviscross traviscross changed the title Tracking Issue for derive(UnsizeInner) Tracking issue for RFC 3621: derive(UnsizeInner) Oct 2, 2024
@traviscross traviscross changed the title Tracking issue for RFC 3621: derive(UnsizeInner) Tracking issue for RFC 3621: derive(SmartPtr) Oct 3, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Oct 7, 2024
…r=pnkfelix

Don't allow the `#[pointee]` attribute where it doesn't belong

Error if the `#[pointee]` attribute is applied to anything but generic type parameters.

Closes rust-lang#128485
Related to rust-lang#123430
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 7, 2024
Rollup merge of rust-lang#128721 - Brezak:pointee-in-strange-places, r=pnkfelix

Don't allow the `#[pointee]` attribute where it doesn't belong

Error if the `#[pointee]` attribute is applied to anything but generic type parameters.

Closes rust-lang#128485
Related to rust-lang#123430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-experimental Blocker: In-tree experiment; RFC pending, not yet approved or unneeded. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. F-derive_smart_pointer `#![feature(derive_smart_pointer)]` S-tracking-impl-incomplete Status: The implementation is incomplete. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants