Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding _int.to_str triples time to compile standard library #124

Closed
jyasskin opened this issue Jul 24, 2010 · 4 comments
Closed

Adding _int.to_str triples time to compile standard library #124

jyasskin opened this issue Jul 24, 2010 · 4 comments

Comments

@jyasskin
Copy link
Contributor

Before jyasskin/rust@684502b:
$ time ./rustboot -L . -shared -o libstd.dylib lib/std.rc
real 0m1.205s; 0m1.168s; 0m1.159s

After:
$ time ./rustboot -L . -shared -o libstd.dylib lib/std.rc
real 0m3.375s; 0m3.571s; 0m3.421s

This is with CFG_NATIVE=1. There must be something pathological in the compiler. A 40-line function shouldn't be able to triple the build time.

@graydon
Copy link
Contributor

graydon commented Jul 25, 2010

Yeah. I think I added a bit too much un-guarded logging in the past week. I'll do a profile-and-shave run on monday and should get it back down a ways.

@graydon
Copy link
Contributor

graydon commented Jul 26, 2010

Good news: found the source of pain. Bad news: will take a little bit of time to fix. On it this afternoon.

@graydon
Copy link
Contributor

graydon commented Jul 26, 2010

I think this is fixed enough to be tolerable for now. There is still a bit of a sore spot in the RA but it's nothing spectacularly non-local or non-linear like you were seeing. Let me know if you are feeling it slowing down again.

@graydon
Copy link
Contributor

graydon commented Jul 27, 2010

Er, for reference sake the commit that did most of the fixing was 3d69407.

oli-obk added a commit to oli-obk/rust that referenced this issue Jul 19, 2017
dlrobertson pushed a commit to dlrobertson/rust that referenced this issue Nov 29, 2018
The unit value is not a literal, it is a tuple expression
eddyb pushed a commit to eddyb/rust that referenced this issue Jun 30, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants