-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding _int.to_str triples time to compile standard library #124
Comments
Yeah. I think I added a bit too much un-guarded logging in the past week. I'll do a profile-and-shave run on monday and should get it back down a ways. |
Good news: found the source of pain. Bad news: will take a little bit of time to fix. On it this afternoon. |
I think this is fixed enough to be tolerable for now. There is still a bit of a sore spot in the RA but it's nothing spectacularly non-local or non-linear like you were seeing. Let me know if you are feeling it slowing down again. |
Er, for reference sake the commit that did most of the fixing was 3d69407. |
The unit value is not a literal, it is a tuple expression
Rustup to the latest nightly
Before jyasskin/rust@684502b:
$ time ./rustboot -L . -shared -o libstd.dylib lib/std.rc
real 0m1.205s; 0m1.168s; 0m1.159s
After:
$ time ./rustboot -L . -shared -o libstd.dylib lib/std.rc
real 0m3.375s; 0m3.571s; 0m3.421s
This is with CFG_NATIVE=1. There must be something pathological in the compiler. A 40-line function shouldn't be able to triple the build time.
The text was updated successfully, but these errors were encountered: