Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

semver: ignore build metadata #12438

Closed
omasanori opened this issue Feb 21, 2014 · 2 comments · Fixed by #12454
Closed

semver: ignore build metadata #12438

omasanori opened this issue Feb 21, 2014 · 2 comments · Fixed by #12454

Comments

@omasanori
Copy link
Contributor

To provide strict total ordering for semver::Version, build metadata must be ignored for equality. Which way is preferred?

  • Preserve build metadata in Version but equality checking ignores it.
    • Most of behaviors are preserved.
  • Remove build metadata field from Version and the parser ignores it.
    • format!("{}", parse("1.0.0+build.1").unwrap()) == "1.0.0"

cc #12435
@erickt
Copy link
Contributor

erickt commented Feb 21, 2014

I we should keep the build data and exclude it from the equality and ordering check. That way we can convert a version back into a string.

@omasanori
Copy link
Contributor Author

@erickt Sure.

@omasanori omasanori mentioned this issue Feb 21, 2014
Merged
bors added a commit that referenced this issue Feb 24, 2014
@bors
auto merge of #12454 : omasanori/rust/semver-eq, r=alexcrichton
7e60fc6 
Closes #12438
bors added a commit that referenced this issue Feb 25, 2014
@bors
auto merge of #12454 : omasanori/rust/semver-eq, r=alexcrichton
043c972 
Closes #12438
@bors bors closed this as completed in b0a495f Feb 25, 2014
bors added a commit to rust-lang-ci/rust that referenced this issue Mar 20, 2023
@bors
Auto merge of rust-lang#13789 - feniljain:fix_enum_completion, r=Veykril
7c05f55 
feat: show only missing variant suggestion for enums in patterns completion and bump them in list too

Fixes rust-lang#12438

### Points to help in review:

- This PR can be reviewed commit wise, first commit is about bumping enum variant completions up in the list of completions and second commit is about only showing enum variants which are not complete
- I am calculating missing variants in analysis.rs by firstly locating the enum and then comparing each of it's variant's name and checking if arm string already contains that name, this is kinda hacky but I didn't want to implement complete missing_arms assist here as that would have been too bulky to run on each completion cycle ( if we can improve this somehow would appreciate some inputs on it )

### Output:

https://user-images.githubusercontent.com/49019259/208245540-57d7321b-b275-477e-bef0-b3a1ff8b7040.mov

Relevant Zulip Discussion: https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer/topic/Issue.20.2312438
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this issue Mar 21, 2024
@MarcusGrass
Fix rust-lang#12438 false positive regression
b44ab66
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this issue Mar 21, 2024
@bors
Auto merge of rust-lang#12447 - MarcusGrass:mg/fix-12438-regression, …
7ee75f8 
…r=y21

Fix rust-lang#12438 std_instead_of_core regression

Fixes rust-lang#12438.

Boy-scouting removed two paths that checks for duplication since I thought they were unused. However, that's just because I didn't spot it in the diff.

I installed [difftastic](https://github.com/Wilfred/difftastic) and ran it on the old one:

![image](https://github.com/rust-lang/rust-clippy/assets/34198073/5c51276c-055a-49a3-9425-6f7da0590fb0)

And the new one (fixed):

![image](https://github.com/rust-lang/rust-clippy/assets/34198073/6e10f29c-6d6b-4f64-893f-de526424f1cd)

New one (stderr):
![image](https://github.com/rust-lang/rust-clippy/assets/34198073/c4c07776-ee0f-47ba-996f-6b632de47c81)

Good teachings for the future when inspecting diffs with a lot of line changes, should've thought of that before, sorry for the trouble!

changelog: [`std_instead_of_core`] Fix false positive for crates that are in `std` but not `core`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude build metadata from equality checking
2 participants
@erickt @omasanori