Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move -Z lto to -C lto #12443

Closed
thestinger opened this issue Feb 21, 2014 · 2 comments · Fixed by #17421
Closed

move -Z lto to -C lto #12443

thestinger opened this issue Feb 21, 2014 · 2 comments · Fixed by #17421
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@thestinger
Copy link
Contributor

It doesn't make sense as a debug option. This was where experimental options used to go but the documentation now just says they're debugging flags.
@alexcrichton
Copy link
Member

I initially didn't do this because I wasn't convinced that we're satisfied without LTO works right now, so I figured we should reserve the right to change it. That being said, we're also not sure that -C link-args will always be supported, yet I went ahead and moved it. It's probably ok to move.

@reem
Copy link
Contributor

reem commented Sep 15, 2014

Triage: This should probably be moved as it's not a debugging flag.

@thestinger thestinger added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Sep 15, 2014
@thestinger thestinger mentioned this issue Sep 16, 2014
Closed
@colrdavidson colrdavidson mentioned this issue Sep 21, 2014
Merged
bors added a commit that referenced this issue Sep 21, 2014
@bors
auto merge of #17421 : anchovieshat/rust/move_lto, r=thestinger
b8599ec 
Closes #12443
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
@bors
Auto merge of rust-lang#12443 - Veykril:fmtfix, r=Veykril
6f7c558 
minor: Fix rustfmt failing on main_loop.rs
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this issue Mar 21, 2024
@bors
Auto merge of rust-lang#12443 - cookie-s:noeffectreoplace-fix-dup-dia…
099e2c0 
…gs, r=Alexendoo

[`no_effect_replace`]: Fix duplicate diagnostics

Relates to rust-lang#12379

Fixes `no_effect_replace` duplicate diagnostics

---

changelog: [`no_effect_replace`]: Fix duplicate diagnostics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move -Z lto to -C lto.
3 participants
@alexcrichton @thestinger @reem