Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f16/f128 fallback code is not getting inlined #125229

Closed
tgross35 opened this issue May 17, 2024 · 4 comments · Fixed by #125252
Closed

f16/f128 fallback code is not getting inlined #125229

tgross35 opened this issue May 17, 2024 · 4 comments · Fixed by #125252
Labels
C-bug Category: This is a bug. F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@tgross35
Copy link
Contributor

From @ojeda, RUSTC_BOOTSTRAP=1 rustc --edition=2021 -Csymbol-mangling-version=v0 --cfg no_fp_fmt_parse --crate-type rlib library/core/src/lib.rs --sysroot=/dev/null ICEs at no symbol mangling. --cfg no_fp_fmt_parse is required for the repro.

The symbol mangling ICE was fixed in #123816 which is nominated for beta backport, but this seems to hint that something isn't marked #[inline] that should be. I suspect that adding the above --cfg would probably break cg_gcc and cg_clif.

From Miguel, this uses the most recent beta rustc 1.79.0-beta.4 (a26981974 2024-05-10)
@tgross35 tgross35 added the C-bug Category: This is a bug. label May 17, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 17, 2024
@tgross35
Copy link
Contributor Author

@rustbot label +F-f16_and_f128 +T-libs -needs-triage

@rustbot rustbot added F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels May 17, 2024
@ojeda ojeda mentioned this issue May 17, 2024
Open
50 tasks
@fmease fmease changed the title f16/`f128 fallback code is not getting inlined f16/f128 fallback code is not getting inlined May 17, 2024
@beetrees
Copy link
Contributor

beetrees commented May 18, 2024 •
edited
Loading

The fallback Debug impls for f16 and f128 are lacking an #[inline] hint here.

@tgross35
Copy link
Contributor Author

tgross35 commented May 18, 2024 •
edited
Loading

I did see that, just didn’t get a chance to test a fix for it yet. Care to put a patch up? (If not, I'll get to it at some point)

@beetrees beetrees mentioned this issue May 18, 2024
Merged
@beetrees
Copy link
Contributor

PR at #125252.

@bors bors closed this as completed in edace32 May 19, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue May 19, 2024
@rust-timer
Unrolled build for rust-lang#125252
15e3bc5 
Rollup merge of rust-lang#125252 - beetrees:patch-1, r=joboet

Add `#[inline]` to float `Debug` fallback used by `cfg(no_fp_fmt_parse)`

Fixes rust-lang#125229.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add #[inline] to float Debug fallback used by cfg(no_fp_fmt_parse) beetrees/rust
3 participants
@tgross35 @rustbot @beetrees