-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"--json-output" is ignored by tool builds #125666
Comments
For tools, we handle the build results later even if they fail: rust/src/bootstrap/src/core/build_steps/tool.rs Lines 114 to 134 in 7717a30
|
All this toolstate stuff is not needed any more, though. We only use toolstate for books these days, so the tools can be cleaned up. |
…=albertlarsan68 prefer `compile::stream_cargo` for building tools Previously, we were running bare commands for `ToolBuild` step and were unable to utilize some of the flags which are already handled by `compile::stream_cargo`. This change makes `ToolBuild` to use `compile::stream_cargo`, allowing us to benefit from the flags supported by the bootstrap cargo. Resolves rust-lang#125666
…=albertlarsan68 prefer `compile::stream_cargo` for building tools Previously, we were running bare commands for `ToolBuild` step and were unable to utilize some of the flags which are already handled by `compile::stream_cargo`. This change makes `ToolBuild` to use `compile::stream_cargo`, allowing us to benefit from the flags supported by the bootstrap cargo. Resolves rust-lang#125666
Rollup merge of rust-lang#125781 - onur-ozkan:improve-tool-builder, r=albertlarsan68 prefer `compile::stream_cargo` for building tools Previously, we were running bare commands for `ToolBuild` step and were unable to utilize some of the flags which are already handled by `compile::stream_cargo`. This change makes `ToolBuild` to use `compile::stream_cargo`, allowing us to benefit from the flags supported by the bootstrap cargo. Resolves rust-lang#125666
Thanks for the fix :) |
When doing something like
./x.py build miri --json-output
, then the errors/warnings in Miri itself are still reported in the normal, human-readable form, and not as JSON.I assume something somewhere around here has to use a different function for running cargo, e.g. this one.
Cc @onur-ozkan
The text was updated successfully, but these errors were encountered: