Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/librustc/middle/typeck/infer/test.rs needs salvaging #12585

Closed
alexcrichton opened this issue Feb 27, 2014 · 1 comment
Closed

src/librustc/middle/typeck/infer/test.rs needs salvaging #12585

alexcrichton opened this issue Feb 27, 2014 · 1 comment

Comments

@alexcrichton
Copy link
Member

Currently this file is not being compiled. In #12564 it was indicated that this should be fixed rather than removed.
@alexcrichton alexcrichton mentioned this issue Feb 27, 2014
Closed
@steveklabnik
Copy link
Member

I uh, can't find this file now. @alexcrichton if you remember which one this is, give a shout.

flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 18, 2024
@bors
Auto merge of rust-lang#12591 - y21:issue12585, r=Jarcho
8253040 
type certainty: clear `DefId` when an expression's type changes to non-adt

Fixes rust-lang#12585

The root cause of the ICE in the linked issue was in the expression `one.x`, in the array literal.

The type of `one` is the `One` struct: an adt with a DefId, so its certainty is `Certain(def_id_of_one)`. However, the field access `.x` can then change the type (to `i32` here) and that should update that `DefId` accordingly. It does do that correctly when `one.x` would be another adt with a DefId:

https://github.com/rust-lang/rust-clippy/blob/97ba291d5aa026353ad93e48cf00e06f08c73830/clippy_utils/src/ty/type_certainty/mod.rs#L90-L91

but when it *isn't* an adt and there is no def id (which is the case in the linked issue: `one.x` is an i32), it keeps the `DefId` of `One`, even though that's the wrong type (which would then lead to a contradiction later when joining `Certainty`s):
https://github.com/rust-lang/rust-clippy/blob/97ba291d5aa026353ad93e48cf00e06f08c73830/clippy_utils/src/ty/type_certainty/mod.rs#L92-L93

In particular, in the linked issue, `from_array([one.x, two.x])` would try to join the `Certainty` of the two array elements, which *should* have been `[Certain(None), Certain(None)]`, because `i32`s have no `DefId`, but instead it was `[Certain(One), Certain(Two)]`, because the DefId wasn't cleared from when it was visiting `one` and `two`. This is the "contradiction" that could be seen in the ICE message

... so this changes it to clear the `DefId` when it isn't an adt.

cc `@smoelius` you implemented this initially in rust-lang#11135, does this change make sense to you?

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steveklabnik @alexcrichton