ICE after renaming trait on nightly 1.80

[tower120]

I got an ICE after renamed MaybeEmpty trait on crate root into Empty.
cargo clean solved an issue.
Project is on public github https://github.com/tower120/hi_sparse_array/blob/5910c9352d3494084514f68d6a0f684324dea83a/src/lib.rs#L115.

rustc-ice-2024-06-09T04_06_53-9792.txt
rustc-ice-2024-06-09T04_07_09-12764.txt

[fmease]

Hey, thanks for your report! This seems to be an incremental compilation bug.
Unfortunately I'm unable to reproduce this as is. Below are my exact steps.
If you are able to consistently reproduce this ICE when renaming the trait,
please tell us the reproduction steps in as much detail as possible. Thanks! :)

git clone https://github.com/tower120/hi_sparse_array.git
cd hi_sparse_array
git checkout 5910c9352d3494084514f68d6a0f684324dea83a
rustup install nightly-2024-05-07 --profile minimal
cargo +nightly-2024-05-07 build
sed -i 's/\bMaybeEmpty\b/Empty/g' **/*.rs
cargo +nightly-2024-05-07 build

[fmease]

I also tried

• \b(?<!\[)MaybeEmpty\b → Empty with VS Code search & replace, i.e., every occurrence except intra-doc links like [MaybeEmpty]
• rust-analyzer's rename
• sed -i 's/\bMaybeEmpty\b/Empty/g' src/lib.rs (crate root only)

to no avail

[tower120]

I used RustRover for rename. And compiled with CTRL+F9. Also cargo test --tests.

I get such ICE's from time to time, but not consistently. I also CONSTANTLY loose debug capabilities in random files of project. Both VSCode and RustRover says something like "debuggable file does not have debug info" or that it mismatch.

There is bench.bat in project, It compiles and run project with target-cpu=native. Maybe that is the reason? Maybe build system somehow mess with different build configs?

I also have several chains - nightly, stable, and some 1.7x. Project requires nightly mode (but not nightly chain), and I think I changed default chain previously...

[tower120]

Maybe you could walk several revision back from master, and then incrementally one-by-one go forth and try to compile, bench and test at each revision. That rename is in master branch now.

[pacak]

I couldn't reproduce it either, but I think #126409 might help to deal with that.

[pacak]

Can you check if you can reproduce it in current nightly?

[tower120]

I sorry, but that was not reproducible for me from the start.
I just get ICE after CTRL+F9 and saw generated ice report in the project root.
I get ICEs after that, but I can't tell what I did to encounter them.

My guess is that RustRover use some nightly flags for better warning/error messages that could cause that,
since as soon as I disabled them and switched to 1.79 stable - I did not saw ICEs anymore.

[pacak]

Can you try to enable those nightly flags again and see if this happens before current nightly but not after so we can close this ticket?

[tower120]

I don't know how to get that ICE. I thought that happened due to rename - but I was wrong.

I checked on nightly that I had and it compiled just fine.
I tried current nightly - and no ICE as well.

[tower120]

I think you may close this. I reopen issue if I encounter that again.