-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inherent method selection uses subtyping even when using paths #126227
Labels
T-types
Relevant to the types team, which will review and decide on the PR/issue.
Comments
rustbot
added
the
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
label
Jun 10, 2024
lcnr
added
A-resolve
Area: Path resolution
T-types
Relevant to the types team, which will review and decide on the PR/issue.
and removed
A-resolve
Area: Path resolution
labels
Jun 10, 2024
saethlin
removed
the
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
label
Jul 4, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Aug 14, 2024
…=<try> Relate receiver invariantly in method probe for `Mode::Path` Reverts rust-lang#126128 Fixes the part of rust-lang#122317 which always used subtyping instead of eq Fixes rust-lang#126227 (TODO: test) WIP: description r? lcnr
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this issue
Sep 17, 2024
… r=lcnr Relate receiver invariantly in method probe for `Mode::Path` Effectively reverts part of rust-lang#126128 Fixes rust-lang#126227 This PR changes method probing to use equality for fully path-based method lookup, and subtyping for receiver `.` method lookup. r? lcnr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I would like us to change method selection for associated items to use equality. It feels very wrong to completely ignore the user type annotation here:
cc #126128 @compiler-errors @oli-obk
The text was updated successfully, but these errors were encountered: