compiletest: Printing process output panics if the output contains unknown JSON-like text #126373
Labels
A-compiletest
Area: The compiletest test runner
A-testsuite
Area: The testsuite used to check the correctness of rustc
C-bug
Category: This is a bug.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
rustbot
added
needs-triage
github-project-automation
bot
moved this to Backlog
in compiletest maintenance and improvements
|
The obvious solution (just make it not panic) is complicated by the fact that |
jieyouxu
added
A-testsuite
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Aug 13, 2024
compiletest: Don't panic on unknown JSON-like output lines
The `json::extract_rendered` function is called for both compiler output and non-compiler output, so it's inappropriate to panic just because a line starting with `{` didn't contain a compiler output message.
It is called from two places: when checking the output of a `ui` test process, and when printing the output of an arbitrary non-passing `ProcRes`. So unfortunately there's currently no easy way to know for sure whether it is seeing compiler output or not. Fortunately, neither call site appears to be relying on this panic; it's just an overzealous internal check.
Fixes rust-lang#126373.
github-project-automation
bot
moved this from Backlog
to Done
in compiletest maintenance and improvements
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Aug 14, 2024
Rollup merge of rust-lang#129049 - Zalathar:json-like, r=jieyouxu compiletest: Don't panic on unknown JSON-like output lines The `json::extract_rendered` function is called for both compiler output and non-compiler output, so it's inappropriate to panic just because a line starting with `{` didn't contain a compiler output message. It is called from two places: when checking the output of a `ui` test process, and when printing the output of an arbitrary non-passing `ProcRes`. So unfortunately there's currently no easy way to know for sure whether it is seeing compiler output or not. Fortunately, neither call site appears to be relying on this panic; it's just an overzealous internal check. Fixes rust-lang#126373.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a process unexpectedly fails/succeeds, compiletest will often print a full dump of its stdout and stderr for diagnostic purposes.
When this happens,
ProcRes::print_infocalls intoextract_rendered, which has special handling for lines starting with{. It tries to parse the line as JSON in one of a few known compiler-specific formats, in order to replace it with a more human-friendly message.If the line doesn't match any of those formats (or isn't valid JSON), the extractor code will panic, instead of just printing the line as-is. This is awkward in cases where we actually wanted to print the line as-is anyway, because now the error messages are less helpful.
@rustbot label +A-compiletest
The text was updated successfully, but these errors were encountered: