-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking Issue for async drop codegen #126482
Labels
A-async-await
Area: Async & Await
AsyncAwait-Triaged
Async-await issues that have been triaged during a working group meeting.
C-tracking-issue
Category: An issue tracking the progress of sth. like the implementation of an RFC
F-async_drop
Async drop
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-lang
Relevant to the language team, which will review and decide on the PR/issue.
WG-async
Working group: Async & await
Comments
zetanumbers
added
the
C-tracking-issue
Category: An issue tracking the progress of sth. like the implementation of an RFC
label
Jun 14, 2024
@rustbot label +T-compiler +T-lang +WG-async +A-async-await +F-async-drop |
petrochenkov
added
T-lang
Relevant to the language team, which will review and decide on the PR/issue.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
A-async-await
Area: Async & Await
WG-async
Working group: Async & await
F-async_drop
Async drop
labels
Jun 14, 2024
This was referenced Jun 17, 2024
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jun 17, 2024
…sue, r=petrochenkov Add tracking issue number to async_drop APIs Relates to tracking issue rust-lang#126482 r? `@petrochenkov`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jun 17, 2024
…sue, r=petrochenkov Add tracking issue number to async_drop APIs Relates to tracking issue rust-lang#126482 r? ``@petrochenkov``
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jun 17, 2024
Rollup merge of rust-lang#126596 - zetanumbers:async-drop-tracking-issue, r=petrochenkov Add tracking issue number to async_drop APIs Relates to tracking issue rust-lang#126482 r? ``@petrochenkov``
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
Jun 18, 2024
…drop-glue, r=oli-obk Make async drop code more consistent with regular drop code Fixes rust-lang#126573 Relates to rust-lang#126482 r? `@petrochenkov`
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this issue
Jun 19, 2024
…drop-glue, r=oli-obk Make async drop code more consistent with regular drop code Fixes rust-lang#126573 Relates to rust-lang#126482 r? ``@petrochenkov``
fmease
added a commit
to fmease/rust
that referenced
this issue
Jun 19, 2024
…drop-glue, r=oli-obk Make async drop code more consistent with regular drop code Fixes rust-lang#126573 Relates to rust-lang#126482 r? ```@petrochenkov```
fmease
added a commit
to fmease/rust
that referenced
this issue
Jun 19, 2024
…drop-glue, r=oli-obk Make async drop code more consistent with regular drop code Fixes rust-lang#126573 Relates to rust-lang#126482 r? ````@petrochenkov````
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jun 19, 2024
Rollup merge of rust-lang#126594 - zetanumbers:fix-cross-crate-async-drop-glue, r=oli-obk Make async drop code more consistent with regular drop code Fixes rust-lang#126573 Relates to rust-lang#126482 r? ````@petrochenkov````
traviscross
added
the
AsyncAwait-Triaged
Async-await issues that have been triaged during a working group meeting.
label
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-async-await
Area: Async & Await
AsyncAwait-Triaged
Async-await issues that have been triaged during a working group meeting.
C-tracking-issue
Category: An issue tracking the progress of sth. like the implementation of an RFC
F-async_drop
Async drop
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-lang
Relevant to the language team, which will review and decide on the PR/issue.
WG-async
Working group: Async & await
This is a tracking issue for the async drop codegen from MCP "727" (rust-lang/compiler-team#727).
The feature gate for the issue is
#![feature(async_drop))]
.About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Discussion comments will get marked as off-topic or deleted.
Repeated discussions on the tracking issue may lead to the tracking issue getting locked.
Steps
AsyncDrop
trait (Add simple async drop glue generation #121801)async_drop_in_place_raw
/async drop glue generation support fordyn Trait
)AsyncDrop
implementation requires same bounds as type definitionneeds_async_drop
in rustc and optimize async drop glue #124662)TyKind::AdtAsyncDestructor
and get rid of combinatorsFormatting for new syntax has been added to the Style Guide (nightly-style-procedure)Unresolved Questions
dyn Trait
)AsyncDrop
andDrop
should somehow be combined to not duplicate implementations (possibly outside of the scope of this tracking issue)Implementation history
needs_async_drop
in rustc and optimize async drop glue #124662The text was updated successfully, but these errors were encountered: