Refactor rvalue datums in trans to carry the expression id from which they originated #12731
Labels
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
Comments
|
Sounds like this could simplify a datumized trans (which I've yet to get to doing), I'll keep it in mind. |
steveklabnik
added
the
C-cleanup
|
@nikomatsakis is this refactoring still relevant? |
|
Given that it's been a year with no update, I'm giving it a close. @nikomatsakis let me know if you think it's still relevant to keep open. |
|
On Tue, Feb 02, 2016 at 10:27:23AM -0800, Steve Klabnik wrote:
Nah, MIR makes this irrelevant. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
May 17, 2024
make [`from_str_radix_10`] skip constant context fixes: rust-lang#12731 --- changelog: make [`from_str_radix_10`] skip constant context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently in trans rvalue datums do not know the expr id from which they originated. As a result, many parts of the code must track this separately, so that if we have to add a temporary cleanup, we can select the appropriate cleanup scope (which is a function of the trans id). I've been wanting for a while to refactor things so that the
Rvaluetype carries this node-id along with it.cc @eddyb, this kind of refactoring might interest you
The text was updated successfully, but these errors were encountered: