-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tool::prepare_tool_cargo
should run builder.ensure
automatically, based on tool mode
#128012
Comments
Tools test steps usually ensure their corresponding step in rust/src/bootstrap/src/core/build_steps/tool.rs Lines 71 to 89 in 2e6fc42
So, if you add this new tool under |
I opened this because a few other tools seem to call Are you saying that the new |
I think the right pattern should be having a specific build step in tool module (so we can also build it with |
Alright, it ideally would also have a |
I was somewhat thrown off by 6062059#diff-675065335a90de4a4e1ac5bc0a078709f865ff2d357ba2650309f0ad8614b1d3R3531-R3549; setting
Mode::ToolStd
or some of the otherMode::Tool*
options caused acan't find crate for `core`
(and std) error. This was fixed by addingbuilder.ensure(compile::Std::new(compiler, bootstrap_host));
.Since
prepare_tool_cargo
knows the mode, it should just callbuilder.ensure
itself. This manual ensure could then be removed from the rest ofbuild_steps/test.rs
.The text was updated successfully, but these errors were encountered: