-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation LaTeX generation creates files that make pdflatex handle non-ASCII characters incorrectly #12804
Comments
I guess this might be a bug in pandoc... I don't really know. (The encoded character is U+03C0, i.e. it's not some peculiar pi glyph from a higher plane or anything like that.) |
The above file works with both lualatex and xelatex i.e. it's pdflatex specific (which makes sense since the former two are designed for unicode input). |
This restores the old behaviour (as compared to building PDF versions of all standalone docs), because some of the guides use unicode characters, which seems to make pdftex unhappy.
cc me |
@huonw after reading some Q/A sites and finding the following links:
I now have this variant of your file which does seem to render on my copy of \documentclass{article}
\usepackage[LGRx,T1]{fontenc}
\usepackage[utf8]{inputenc}
\usepackage{textgreek}
\begin{document}
π
\end{document} |
I get the feeling that the comment
on the first link is the correct solution: we live in a unicode world, so we might as well just use a unicode engine, rather than trying to bash |
@huonw I don't personally mind depending on XeLaTeX or some other unicode-enabled latex (as long as we select one that has wide support for our hosts, i.e. Mac OS X and Linux ... not sure if Windows/MinGW is as much as a priority as the other two). |
And some quick browsing suggests LuaTex is supported by those 3 distributions too (not 100% sure about MiKTeX), so it seems that platform support shouldn't be a problem. |
TeXLive installs all major compilers indeed.
|
@adrientetar the problem isn't whether |
@pnkfelix We can use |
BTW, are we really willing to make PDFs for guides? These just seem like quick things that you'd read up rapidly, not sure we need a LaTeX PDF for that. |
@adrientetar IMO we don't need PDFs at all, though I understand the desire to have a printable manual. |
Fix would be to build with lualatex OR xelatex OR pdflatex (the opposite of what we’re doing now), code is here: lualatex has been endorsed as pdflatex’s successor and ships with texlive since quite some time now. |
Bugs in pdflatex (#12804) are preventing the guide from landing (#16657). This solves the immediate problem by changing the build system to prefer lualatex, xelatex to pdflatex (which is apparently obsolete). Because the xelatex on the snapshot bot seems to completely ignore the `-output-directory` option, I also had to frob the makefiles a bit for that case.
I think since we have the preferred latex stuff in the right order, this is effectively good enough. |
…kril fix: make file watcher config a drop-down (and clarify the options) Fixes rust-lang/rust-analyzer#12794 Also renames "notify" to "server", since that's clearer ("notify" is still accepted for compatibility).
fulfill expectations in `check_unsafe_derive_deserialize` The utility function `clippy_utils::fulfill_or_allowed` is not used because using it would require to move the check for allowed after the check iterating over all inherent impls of the type, doing possibly unnecessary work. Instead, `is_lint_allowed` is called as before, but additionally, once certain that the lint should be emitted, `span_lint_hir_and_then` is called instead of `span_lint_and_help` to also fulfill expectations. Note: as this is my first contribution, please feel free to nitpick or request changes. I am happy to adjust the implementation. fixes: rust-lang#12802 changelog: fulfill expectations in [`unsafe_derive_deserialize`]
fulfill expectations in `check_partial_eq_without_eq` This is a followup to rust-lang#12804, fixing a similar issue for `derive_partial_eq_without_eq` by using `span_lint_hir_and_then` instead of `span_lint_and_sugg`. Additionally tests for both `#[allow(clippy::derive_partial_eq_without_eq)]` and `#[expect(clippy::derive_partial_eq_without_eq)]` are added. changelog:[`derive_partial_eq_without_eq`]: fulfill expectations
It seems our invocation of Pandoc on some files (e.g.
guide-tasks.md
) creates something equivalent to:which causes the following error
The relevant section of (my) inputenc docs is:
The text was updated successfully, but these errors were encountered: