Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library/std/src/sys/pal/unix/process/process_unix/tests.rs failed in odd arch #128816

Closed
minxuanz opened this issue Aug 8, 2024 · 1 comment
Closed

library/std/src/sys/pal/unix/process/process_unix/tests.rs failed in odd arch #128816

minxuanz opened this issue Aug 8, 2024 · 1 comment
Labels
C-bug Category: This is a bug. O-MIPS Target: MIPS processors O-SPARC Target: SPARC processors T-libs Relevant to the library team, which will review and decide on the PR/issue.

Comments

@minxuanz
Copy link
Contributor

minxuanz commented Aug 8, 2024

rust/library/std/src/sys/pal/unix/process/process_unix/tests.rs

Lines 26 to 29 in 9337f7a

if cfg!(target_os = "linux") {
t(0x0137f, "stopped (not terminated) by signal: 19 (SIGSTOP)");
t(0x0ffff, "continued (WIFCONTINUED)");
}

https://github.com/rust-lang/libc/blob/0e28c864c25d2e9b0ab082947445efccef213da4/src/unix/linux_like/linux/musl/b64/mips64.rs#L586-L589

https://github.com/rust-lang/libc/blob/0e28c864c25d2e9b0ab082947445efccef213da4/src/unix/linux_like/linux/gnu/b64/sparc64/mod.rs#L330-L333

I gusse In mips and sparc arch ,signal 19 is SIGPWR and SIGCONT
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 8, 2024
@jieyouxu jieyouxu added O-MIPS Target: MIPS processors O-SPARC Target: SPARC processors C-bug Category: This is a bug. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 8, 2024
@workingjubilee
Copy link
Member

Please feel free to PR using the libc constants into that test!

@minxuanz minxuanz mentioned this issue Aug 9, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 9, 2024
@matthiaskrgr
Rollup merge of rust-lang#128859 - MinxuanZ:mips-sig, r=Amanieu
0d8054a 
Fix the name of signal 19 in library/std/src/sys/pal/unix/process/process_unix/tests.rs for mips/sparc linux

relate to rust-lang#128816
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 9, 2024
@matthiaskrgr
Rollup merge of rust-lang#128859 - MinxuanZ:mips-sig, r=Amanieu
2330192 
Fix the name of signal 19 in library/std/src/sys/pal/unix/process/process_unix/tests.rs for mips/sparc linux

relate to rust-lang#128816
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 9, 2024
@GuillaumeGomez
Rollup merge of rust-lang#128859 - MinxuanZ:mips-sig, r=Amanieu
3c00848 
Fix the name of signal 19 in library/std/src/sys/pal/unix/process/process_unix/tests.rs for mips/sparc linux

relate to rust-lang#128816
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 9, 2024
@matthiaskrgr
Rollup merge of rust-lang#128859 - MinxuanZ:mips-sig, r=Amanieu
2e0c5ad 
Fix the name of signal 19 in library/std/src/sys/pal/unix/process/process_unix/tests.rs for mips/sparc linux

relate to rust-lang#128816
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Aug 9, 2024
@rust-timer
Unrolled build for rust-lang#128859
2c84138 
Rollup merge of rust-lang#128859 - MinxuanZ:mips-sig, r=Amanieu

Fix the name of signal 19 in library/std/src/sys/pal/unix/process/process_unix/tests.rs for mips/sparc linux

relate to rust-lang#128816
@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. O-MIPS Target: MIPS processors O-SPARC Target: SPARC processors T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@saethlin @jieyouxu @minxuanz @workingjubilee @rustbot