regression: mismatched types

[BoxyUwU]

• https://crater-reports.s3.amazonaws.com/beta-1.81-2/beta-2024-07-26/gh/ltfschoen.kobold-test/log.txt

[INFO] [stdout] error[E0308]: mismatched types
[INFO] [stdout]    --> /opt/rustwide/cargo-home/git/checkouts/kobold-39364116f2711f0d/53eacf6/crates/kobold/src/stateful/hook.rs:167:13
[INFO] [stdout]     |
[INFO] [stdout] 167 |             cb as UnsafeCallback<S>
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^ expected `event::Event<T, E>`, found `web_sys::Event`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `web_sys::Event` and `event::Event<T, E>` have similar names, but are actually distinct types
[INFO] [stdout] note: `web_sys::Event` is defined in crate `web_sys`
[INFO] [stdout]    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/web-sys-0.3.61/src/features/gen_Event.rs:4:1
[INFO] [stdout]     |
[INFO] [stdout] 4   | #[wasm_bindgen]
[INFO] [stdout]     | ^^^^^^^^^^^^^^^
[INFO] [stdout] note: `event::Event<T, E>` is defined in the current crate
[INFO] [stdout]    --> /opt/rustwide/cargo-home/git/checkouts/kobold-39364116f2711f0d/53eacf6/crates/kobold/src/event.rs:12:1
[INFO] [stdout]     |
[INFO] [stdout] 12  | pub struct Event<T = HtmlElement, E = web_sys::Event> {
[INFO] [stdout]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: `dyn CallbackFn<S, web_sys::Event>` implements `CallbackFn` so you could box the found value and coerce it to the trait object `Box<dyn CallbackFn>`, you will have to change the expected type as well
[INFO] [stdout]     = note: this error originates in the attribute macro `wasm_bindgen` (in Nightly builds, run with -Z macro-backtrace for more info)

[compiler-errors]

Apparently this regressed in #127486, but I'm not totally certain which one would've caused this.

[compiler-errors]

Oh, definitely due to the dyn pointer casting #120248: https://github.com/maciejhirsz/kobold/blob/53eacf69d2ea3f25a47e58a3ccd11dcaf73d48bf/crates/kobold/src/stateful/hook.rs#L193-L198

Anyways, this is a very old version of kobold, and it seems like the downstream crate is specifically using a version before this cast is removed.

[apiraino]

Downstream project (kobold-test) doesn't seem super active. Do we want to keep it in our crater run?

[apiraino]

I'm going to close this as not an actionable for us