Allow Numbers After Underscore in Camel Case Types

[bvssvni]

I get this lint on names like:

SVGVersion_1_1

Suggests allowing numbers after underscore by replacing

!ident.contains_char('_')

with

!contains_invalid_after_underscore(ident)

This function to be put within 'is_camel_case':

        // Allow trailing underscore or numeric after underscore.
        fn contains_invalid_after_underscore(ident: &str) -> bool {
            let mut last_was_underscore = false;
            for c in ident.chars() {
                if last_was_underscore && !"_0123456789".contains_char(c) {
                    return true;
                }
                last_was_underscore = c == '_';
            }
            false
        }

Edit: changed to better version suggested by huonw.

[bvssvni]

I did some searching and could not find any precedence for this. The tools that convert from underscore to camel case either removes numbers or merges them together, which means there is no conventions to write multiple numbers in this style. It is easier to add those exceptions later than removing them.

I talked to somebody on the rust-internals IRC channel. One was ok with it (if precedence) and one was against. Nobody was strongly in favor of it, neither am I.

Closing.