-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outdated master branch detection doesn't work with worktrees #130111
Labels
C-bug
Category: This is a bug.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Comments
Noratrieb
added
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
C-bug
Category: This is a bug.
labels
Sep 8, 2024
rustbot
added
the
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
label
Sep 8, 2024
Noratrieb
removed
the
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
label
Sep 8, 2024
i would say adding a bit of error handling that checks if it's in a worktree doesn't sound too hard. there's two options from there:
|
lolbinarycat
added a commit
to lolbinarycat/rust
that referenced
this issue
Sep 8, 2024
This was referenced Sep 9, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Sep 13, 2024
…ream-worktree, r=albertlarsan68 bootstrap: handle worktrees in warn_old_master_branch fixes rust-lang#130111
shrirambalaji
pushed a commit
to shrirambalaji/rust
that referenced
this issue
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-bug
Category: This is a bug.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
When running any bootstrap command, it complains that it can't figure out whether my master branch is outdated.
Of course it does, as it just YOLOs into
.git
, which is just a file and not a directory for worktrees:rust/src/tools/build_helper/src/git.rs
Line 177 in adf8d16
it should probably not do that (i don't have a suggestion on what to do instead)
regressed by #129584 @lolbinarycat @albertlarsan68
The text was updated successfully, but these errors were encountered: