Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x setup tries to check out src/llvm-project #130515

Closed
bjorn3 opened this issue Sep 18, 2024 · 1 comment · Fixed by #130529
Closed

x setup tries to check out src/llvm-project #130515

bjorn3 opened this issue Sep 18, 2024 · 1 comment · Fixed by #130529
Assignees
@onur-ozkan
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@bjorn3
Copy link
Member

bjorn3 commented Sep 18, 2024

This takes quite a while and will end up being wasted effort if the user ends up selecting a profile which uses download-ci-llvm=true anyway.
@bjorn3 bjorn3 added C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 18, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 18, 2024
@bjorn3
Copy link
Member Author

bjorn3 commented Sep 18, 2024

At the same time it doesn't check out any of the submodules that are part of the library workspace and thus are necessary for rust-analyzer to work in the library workspace.

@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 18, 2024
@onur-ozkan onur-ozkan self-assigned this Sep 18, 2024
@onur-ozkan onur-ozkan mentioned this issue Sep 18, 2024
Merged
@bors bors closed this as completed in 13a5097 Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onur-ozkan onur-ozkan

Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change download-ci-llvm default from if-unchanged to true onur-ozkan/rust
4 participants
@bjorn3 @jieyouxu @onur-ozkan @rustbot